Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spells CoolDowns Problems #22354

Open
RioMcBoo opened this issue Aug 30, 2018 · 1 comment
Open

Spells CoolDowns Problems #22354

RioMcBoo opened this issue Aug 30, 2018 · 1 comment

Comments

@RioMcBoo
Copy link
Contributor

Description:

A cooldown on a spell must be set only if it is present (spellInfo->RecoveryTime;) . A cooldown on the category should also be installed only if it is available(spellInfo->CategoryRecoveryTime).

At the core there are methods to specifically pinpoint cooldowns.
(void SpellHistory::GetCooldownDurations)

However, there is an error that is very clearly visible when using the item item = 5205.
While the cooldown on the item is working, the Priest can not use spell = 2052 "Lesser Heal | Rank 2"

Current behaviour:

Expected behaviour:

Steps to reproduce the problem:

Branch(es):

3.3.5

TC rev. hash/commit:

Checking code on current GitHub , a saw it by my eyes.

Operating system: Windows 7

@TrinityCoreBot TrinityCoreBot added the Invalid-IncompleteData/OrNotTrinityCore Reporter deleted parts or all template or he is using a 3rd party unsupported core. label Aug 30, 2018
@TrinityCore TrinityCore deleted a comment from TrinityCoreBot Aug 31, 2018
@Killyana Killyana added Sub-Spells Comp-Core Branch-3.3.5a and removed Invalid-IncompleteData/OrNotTrinityCore Reporter deleted parts or all template or he is using a 3rd party unsupported core. labels Aug 31, 2018
@CraftedRO
Copy link
Contributor

d5b64a0 this seems still valid but I wonder if it shoudn't count as cooldown since the item use same priest spell entry 2052 (Lesser Heal - Rank 2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants