Core/Instance: Reset instance

[Killyana]

Description: If you try to use reset all instances after killing some npcs on non hero dungeon, nothing happen.

Current behaviour: Reset all instance has no effect

Expected behaviour: Reset all instance must reset all non heroic dungeons.

Steps to reproduce the problem:

1. .tele stratholm
2. Go inside the dungeon an kill some npcs
3. get out ".tele stratholm"
4. Right click on your portrait and reset all instances
5. Notice there's no message that say Stratholm is reset
6. Go back inside the dungeon and see the killed npcs are dead, so the dungeon is not reset

Ps: notice if you change dungeon difficulty twice it will reset, but this option is not available before level 70

Branch(es): 3.3.5

TC rev. hash/commit: rev. 28591fd

[ghost]

TrinityCore rev. e5d63bc 2018-09-18 17:11:25 +0200 (3.3.5 branch) (Win64, RelWithDebInfo, Static)
(+ SQL commits 010b872, dd4d646 and 084ec7d)

Unable to replicate this issue directly, tested with all game client addons disabled to see if my "add glyph" issue would go away.
"Reset all dungeons" correctly resets the instance with the message "Stratholme has been reset." each time (4 times).
Going to test with all game addons enabled, now that I can't make my glyph UI work as expected.

---

edit: I was still able to reset the instance a 5. time with the message "Stratholme has been reset." appearing, but now "You have entered too many instances recently." appears correctly. This was tested with all my common addons enabled, even a couple of game addons that tend to lag the game a bit more than practical. Still not able to reproduce this issue as described above.

P.S. I found what was wrong when trying to add a glyph: I tried (unsuccessfully) to drop the actual glyph item inside the glyph UI
instead of right-clicking ("using") the item first, before clicking in the UI. Works as intended, my bad.

---

P.P.S. : I killed Duke Ragereaver (level 45 rare) outside Stratholme before entering. When I entered, I got some damage on my level 59 male orc hunter + Ravager pet (from Hellfire Peninsula). Not sure if that makes any difference. After I killed Duke Ragereaver I waited for him to come riding back towards Stratholme again, but he did not respawn within the 15-20 minutes I waited. Odd, but not related to this issue.

[Killyana]

I tested with a new char and was able to reset the instance, but not with other characters like: https://gist.github.com/Killyana/5a8a002ab2df4f614596d1e85fb7c31b
https://www4.zippyshare.com/v/6Y2AZeli/file.html

[TheWinchesters]

Unable to replicate not using new chars. (I think they are one month old)
I would like to try using your pdump but when I try I get "The dump file contains damaged data!"

TC Rev: e5d63bc

[ghost]

Did you try using the zippyshare version or the gist?
(https://gist.githubusercontent.com/Killyana/5a8a002ab2df4f614596d1e85fb7c31b/raw/a35df541bd58707cebb03cced870fdb49c0f4879/pdump)

Haven't tested any of them myself, but I could try after backing up my DB, then use the .pdump command.

[Killyana]

I updated also the gist.

[TheWinchesters]

This was the error:

LoadPlayerDump: (line 1412) unknown column name itemGuid for table character_aura, aborting due to incompatible DB structure.

Effectively, I can not reset instance with this character.

[TheWinchesters]

I think I found it.
Give me a sec to explain better.

[TheWinchesters]

I saw that your character, Hillium, was the only one with 'instance_mode_mask' 17.
1 → Dungeon difficulty: 5 Player (heroic)
Change that option to 5 Player and you will can reset instance.

https://ibb.co/nzRQKz
If you see the image:
First is Dungeon Difficulty set to 5 Player (Heroic) → Unable to reset instance
Second is Dungeon Difficulty set to 5 Player →Instance has been reset

[Killyana]

Nice catch, so the reset will be done only if the difficulty is set to normal.
Even if you set the difficulty to heroic and kill some npcs into a heroic dungeon, you will not be able to reset this instance, you still need to change the difficulty to normal.

[ghost]

Oh well. I suppose the option to select Heroic is not available on a character below level 80. I presume that is why I was unable to reproduce your issue. I tested with a character level 59 - 60.

[Rockz1152]

I know at some point if you had the difficulty set to heroic and tried to zone in to an instance that did not have a heroic mode, you would get an error "Heroic difficulty is not available" and it would boot you out of the instance. forcing you to change the difficulty back to normal in order to zone in.

Right now you can zone into Stratolme and chat will print "Dungeon Difficulty set to 5 Player (Heroic)" while Statholme did not have a heroic mode.

[Aokromes]

no, instances without heroic mode changes to normal mode since at least cata.
7d353ac

[Rockz1152]

right but in 3.3.5 branch you shouldn't be able to zone into a non-heroic while heroic mode is set, but can still. 010b872

[TheWinchesters]

Is TRANSFER_ABORT_DIFFICULTY = 0x08, // <Normal, Heroic, Epic> difficulty mode is not available for %s. what you are talking about @Rockz1152 ?

[Rockz1152]

I don't get a transfer abort error when zoning in, but now that I think about it more as Aokromes pointed out that, the instance should fall back to normal if heroic isn't available, and it does, so that seems fine.

I guess I just mistook what expansion gave that error, maybe it was early BC and got patched out later.