Nefarian Stage 3

[Lucascn21]

Description:
The adds on phase 3 do not ever come back to life and attack the players.

Current behaviour:
On phase 3, corpses from the mobs we killed during phase 1, do not come back to life as skeletal constructs.

Expected behaviour:
The corpses of the mobs we killed during phase 1 should revive as full hp skeletal constructs on phase 3.

Steps to reproduce the problem:

1. Head to Nefarian (.tele bwl)
2. Start the encounter
3. Kill the adds until Nefarian takes his dragon form
4. Get him below 20% hp
5. Nefarian does the SAY_RAISE_SKELETONS as scripted. Nothing else happens.

Branch(es):
3.3.5
(TDB 335.64)

TC rev. hash/commit:
59682bb

Operating system:
#W10

Notes
I've managed to fix most of this phase but i dont know how to make a Pull Request yet, i will get to it in a few hours.

[ghost]

Feel free to ask for help if you are having trouble creating the PR.
You also have the option to ask in IRC: #Trinity @ irc.rizon.net

[LEO33SoFo]

This problem stills exists as of 9d95912.

And when Nefarian has 5% HP, he should say

ENOUGH! Now you vermin shall feel the force of my birthright: The Fury of the Earth itself!

, according to Wowpedia, which he does not.

[ghost]

(link to the script file)
https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/boss_nefarian.cpp

The OP issue seems to deal mostly with the following part of the script:

TrinityCore/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/boss_nefarian.cpp

Lines 570 to 587 in 41188eb

	// Phase3 begins when health below 20 pct
	if (!Phase3 && HealthBelowPct(20))
	{
	std::list<Creature*> constructList;
	me->GetCreatureListWithEntryInGrid(constructList, NPC_BONE_CONSTRUCT, 500.0f);
	for (std::list<Creature*>::const_iterator itr = constructList.begin(); itr != constructList.end(); ++itr)
	if ((*itr) && !(*itr)->IsAlive())
	{
	(*itr)->Respawn();
	DoZoneInCombat((*itr));
	(*itr)->RemoveFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NOT_SELECTABLE);
	(*itr)->SetReactState(REACT_AGGRESSIVE);
	(*itr)->SetStandState(UNIT_STAND_STATE_STAND);
	}
	Phase3 = true;
	Talk(SAY_RAISE_SKELETONS);
	}

Is there something wrong with if ((*itr) && !(*itr)->IsAlive()) that makes the script skip the Respawn() section completely?