Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue/Red War Fuel #23053

Open
lactoseti opened this issue Feb 17, 2019 · 7 comments
Open

Blue/Red War Fuel #23053

lactoseti opened this issue Feb 17, 2019 · 7 comments

Comments

@lactoseti
Copy link
Contributor

Description:
Blue war fuel (item=46765) and red war fuel appears to cast a spell on the warbot/battlebot, but no buff (filled up) ever goes on it, and the model doesn't change to the respective blue or red bot.

Current behaviour:

npc=34587 is the warbot pet, given by item=46767

You can use item 46765 or 46766 when this pet is out; it will cast a spell with lightning, but no buff ever goes on the pet.

Expected behaviour:

Pet should have buff.

Steps to reproduce the problem:
Pull out pet, use item 46765 or 46766

Branch(es): 3.3.5
TC rev. hash/commit: 58c5dfa
Os: windows 2016 server

@Killyana
Copy link
Member

Many spells must be used by the script: https://woehead.way-of-elendil.fr/?search=Warbot#spells

@lactoseti
Copy link
Contributor Author

When bots of two different colors come within a distance of each other they need to fight. I guess some of those spells are needed for the fight?

@ghost
Copy link

ghost commented Feb 17, 2019

Hmm, isn't the Pet Battles (introduced in Cataclysm) necessary for non-combat pet fights to work?
Expanded: Pet Battle System: (Mists of Pandaria) Patch 5.0.4 (2012-08-28): Added.

@offl
Copy link
Contributor

offl commented Feb 17, 2019

According to spell effects, very likely it's an imitation of fight. I mean they will not be in combat.

@lactoseti
Copy link
Contributor Author

you're right; it's an imitation; it was in game in 2009--in more modern patches (5.x onward) you can buy fuel in dalaran, works the same these days

@lactoseti
Copy link
Contributor Author

I certainly don't mind taking a stab at it myself, but I'm pretty new--maybe could use a general pointer--I've added some custom scripts (for example, I made one to make Landro work and wrote some simple code to let accounts have flags for collector's editions, etc., sends out emails on login to the characters)--can anyone point me to the basic location to put this script for the battlebots?

@ghost
Copy link

ghost commented Feb 18, 2019

I could be mistaken, but I think it more or less depends on what kind of scripts they are.

If they are purely spell scripts, check out the non-player, non-class scripts in
https://github.com/TrinityCore/TrinityCore/tree/3.3.5/src/server/scripts/Spells ,
whereas if the scripts are defined as item or NPC scripts, they likely belong in the
https://github.com/TrinityCore/TrinityCore/tree/3.3.5/src/server/scripts/World
category.


edit: Sorry, I forgot one of the more obvious scripts related to non-combat pets (you may want to focus on this one) :
https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/Pet/pet_generic.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants