Core/Vmap: Collision after a mind control

[Killyana]

Description: When your char get mind controlled you can get weird collision issues.
Like you cannot leave a house because you cannot go throw the door (no gobs)

Steps to reproduce the problem:

1. .go c id 20483
2. Aggro and wait for the mind control
3. .gm on once MC, wait for the MC aura to fad
4. Try to go throw the door

This looks not happening in master

Branch(es): 3.3.5

TC rev. hash/commit: rev. e253b69

[jackpoz]

Any error logged in the console ?

[jackpoz]

Could you try before 8f9654d ?

[Ovahlord]

This is a collision height issue. When the character grows in size with that aura and the collision height will be increased via opcode to reflect that size change but apparently nothing is setting the collision height back to normal once the mindcontrol is removed.

[Killyana]

This issue happen in 2 years old core, it's not new.
I tried .mod scale 0.1 when the mind control ends, But I still cannot go throw the door.

[Shauren]

You need to mount/dismount to trigger SMSG_MOVE_SET_COLLISION_HGT

[Killyana]

If you use .aura 36145 the scale of the char will be changed without the MC effect and you can go throw the door with this scale.
And yes mount/dismount fix the issues but you cannot use the a mount inside the building

[Shauren]

This leads me to think we should be sending SMSG_MOVE_SET_COLLISION_HGT for scale changes for players too (this theory is supported by the fact that on master branch that packet has a field "Reason" where one of the values is MOUNT and the other is just SCALE)