[DK] Anti-Magic Shell

[karolisb]

http://www.wowhead.com/spell=48707
Anti-Magic Shell is a little broken now:
It should defend DK from druid's Cyclone, from shaman's Hex and rogue's Poison application.

Some proofs:
http://www.warcraftmovies.com/movieview.php?id=137567
25:45 and 27:17 it shows, how DK AMS'ed shaman's Hex

Same movie, 28:50 it shows, how rogue gets near DK, DK uses AMS and no poisons gets applied, only runic power gained

[tobmaps]

you can try this https://gist.github.com/1096911 . Mostly based on info from here http://www.wowhead.com/spell=48707#comments:id=1049350 . One of examples why it's based on mechanics - http://www.wowhead.com/spell=66935 (triggers 66862 on normal difficulty and 67681 on heroic) , it should give you immune to aura apply, but damage still should be there (as you can see there is no Dispel types in triggered spell)

But i anyway unsure about my patch because i need to know for example if mage's Fireball should apply debuff or no when you have active Anti-Magic Shield.

And also i don't know if it should prevent aura apply of "ID - 72848 Arctic Breath" or no

[jambonfrite]

8310722 :)

[tobmaps]

8310722 :)

and? This commit will not fix your problem

[jambonfrite]

:(
this worked well on my server so it should work for karolisb i think ;)

[karolisb]

http://www.youtube.com/watch?v=RIsabfXpRNM - 2:00 it shows how mage casts Scorch on AMS and something gets immuned, Living Bomb explodes. Maybe it is related to Fireball somehow. Haven't played for mage so I don't know.

Moreover AMS tooltip says "Prevents application of harmful magical effects". Maybe that Fireball's debuff is an magical effect.

[ghost]

so...? this (8310722) fix are working or not?

[tobmaps]

aios, it will do nothing with Hex and poisons

[ghost]

but do with druid's cyclone yep?

[Warpten]

I personally did

diff --git a/src/server/game/Entities/Unit/Unit.cpp b/src/server/game/Entities/Unit/Unit.cpp
index 755449a..30ceaf2 100755
--- a/src/server/game/Entities/Unit/Unit.cpp
+++ b/src/server/game/Entities/Unit/Unit.cpp
@@ -11659,9 +11660,9 @@ bool Unit::IsImmunedToSpellEffect(SpellInfo const* spellInfo, uint32 index) cons
         // Check for immune to application of harmful magical effects
         AuraEffectList const& immuneAuraApply = GetAuraEffectsByType(SPELL_AURA_MOD_IMMUNE_AURA_APPLY_SCHOOL);
         for (AuraEffectList::const_iterator iter = immuneAuraApply.begin(); iter != immuneAuraApply.end(); ++iter)
-            if (spellInfo->Dispel == DISPEL_MAGIC &&                                      // Magic debuff
-                ((*iter)->GetMiscValue() & spellInfo->GetSchoolMask()) &&  // Check school
-                !spellInfo->IsPositiveEffect(index))                                  // Harmful
+            if ((spellInfo->Dispel == DISPEL_MAGIC || spellInfo->Dispel == DISPEL_CURSE)    // Magic or curse debuff
+                && ((*iter)->GetMiscValue() & spellInfo->GetSchoolMask())                   // Check school
+                && !spellInfo->IsPositiveEffect(index))                                     // Harmful
                 return true;
     }
 

Working with Hex, not tested with other stuff. Most probably hack like because i had no info when i did that.

[ghost]

Thanks _ i merged two pathches)

[Warpten]

I woud personally trust more tobmap's patch. My diff may break some stuff, but i didn't check for that.

[ghost]

i can't find tobmabs patch... do you have it?

[Warpten]

First answer on this issue, first link.

Want binoculars? (sry didnt mean giggles, fr-en translation brain typo :D)

[ghost]

fuck - i don't read this message - very sorry - and thank you...

[SignFinder]

Need fix AM-shell and cyclon for newest TC revision

[MagicCG]

Well, it's quite a simple fix really.

DELETE FROM spell_linked_spell WHERE spell_trigger IN (48707);
INSERT INTO spell_linked_spell (spell_trigger, spell_effect, type, comment) VALUES
('48707', '-33786', '2', 'AMS Immune to Cyclone'),
('48707', '-51514', '2', 'AMS Immune to Hex');

[Warpten]

Also, some people argue you can,t be dispelled under AMS. Any idea?

[MagicCG]

Well

Surrounds the Death Knight in an Anti-Magic Shell, absorbing 75% of the damage dealt by harmful spells (up to a maximum of 50% of the Death Knight's health) and preventing application of harmful magical effects. Lasts 5 sec.

harmful magical effects. <-- Being the key words, i would think not.

[Subv]

#2408