[3.3.5] Core/LFD LBRS tele location&different Instance after wipe

[soniczhang11]

Description:

2 Bugs with LFD

Current behaviour:

1. The tele location for LBRS in LFD system is wrong. Now it tele players to the location near entrance of BWL. It should tele players to the entrance of BRS.

2. When player use LFD and wipe in instance, they may walk in a new instance(all mobs are respawned) after their souls running back. However, players who have not release their souls are still in the old one. It is a annoying issue but appears only sometimes.

Expected behaviour:

1. Fix it.
2. Fix it.

Steps to reproduce the problem:

Branch(es):

3.3.5

TC rev. hash/commit:

4529a94

Operating system: CentOS 7

[Killyana]

I Will try to explain this issue, it's an old one, when players starts a big dungeon specially vanilla 50+ (stratholm, LBRS,..) if after a while a player(s) died and release spirit, when he try to enter the instance to resurrect he will get the message "wrong instance", in this case if he resurrect in the graveyard and try to enter the dungeon he will end up in a different instance than the other players, it's like the first lock is lost or deleted, maybe the soft reset happen even if players are inside the instance and that result the instance ID to be deleted.

[soniczhang11]

I Will try to explain this issue, it's an old one, when players starts a big dungeon specially vanilla 50+ (stratholm, LBRS,..) if after a while a player(s) died and release spirit, when he try to enter the instance to resurrect he will get the message "wrong instance", in this case if he resurrect in the graveyard and try to enter the dungeon he will end up in a different instance than the other players, it's like the first lock is lost or deleted, maybe the soft reset happen even if players are inside the instance and that result the instance ID to be deleted.

That's right. It seems the server resets the Dungeon after wipe.

[Killyana]

This could be related:

Player::_LoadBoundInstances: player 'xxxxxx' (GUID Full: 0x000000000007e0c5 Type: Player Low: 516293) is in group GUID Full: 0x1f500000000001b0 Type: Group Low: 432 but has a non-permanent character bind to map 230 (Profondeurs de Rochenoire), 227, 0

[soniczhang11]

fix LFGDungeons LBRS tele issue and confirmed on my server,

INSERT INTO `lfg_dungeon_template` (`dungeonId`, `name`, `position_x`, `position_y`, `position_z`, `orientation`, `VerifiedBuild`) VALUES (32, 'Lower Blackrock Spire', 78.5083, -225.044, 49.839, 5.1, 12340);
INSERT INTO `lfg_dungeon_template` (`dungeonId`, `name`, `position_x`, `position_y`, `position_z`, `orientation`, `VerifiedBuild`) VALUES (44, 'Upper Blackrock Spire', 78.5083, -225.044, 49.839, 5.1, 12340);

[Jinnaii]

The SQL from @soniczhang11 should be added. Dont know if this is 100% Retail or not but it works correctly.
What currently happens is just wrong. Porting to the entrance of BWL skips big parts of BRS and should not happen.

[ghost]

@soniczhang11 : The TC SQL codestyle version of your suggested solution looks like this:

DELETE FROM `lfg_dungeon_template` WHERE `dungeonId` IN (32, 44);
INSERT INTO `lfg_dungeon_template` (`dungeonId`, `name`, `position_x`, `position_y`, `position_z`, `orientation`, `VerifiedBuild`) VALUES
(32, 'Lower Blackrock Spire', 78.5083, -225.044, 49.839, 5.1, 0),
(44, 'Upper Blackrock Spire', 78.5083, -225.044, 49.839, 5.1, 0);

---

edit: I have replaced your VerifiedBuild 12340 with 0 (zero) because the 12340 value should mostly only be used when you have verified the values from sniffs in online retail 3.3.5a (or if the information can be found when decompiling the game client).

[offl]

Where dungeonId comes from so I can check if it's valid?
Correct positions: 78.3534,-226.841,49.7662,4.71238 -- WSL 3644