Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/GameObject/Pooling: Pooled Goobers respawns instantly if despawned manually #23586

Open
Killyana opened this issue Jul 11, 2019 · 1 comment

Comments

@Killyana
Copy link
Member

Description: If you have a pooled goober (gob type 10) and you use the SAI action 41 to despawn it, the pool will respawn an other gob instantly ignoring the respawn time from gameobject table or the one from the action_param2.

UPDATE `gameobject_template` SET `AIName`='SmartGameObjectAI' WHERE `entry` IN (192708, 192706, 192871, 192905, 192710, 192886, 192869, 192880, 192895, 192713, 192889, 192890, 192894, 192884, 192866, 192891, 192872, 192881, 192709 ,192883 ,192651, 192888, 192711, 192653 ,192887, 192652, 192865, 192874 ,192868, 192870, 192885, 192867, 192882, 192707, 192896);
DELETE FROM `smart_scripts` WHERE `source_type`=1 AND `entryorguid` IN (192708, 192706, 192871, 192905, 192710, 192886, 192869, 192880, 192895, 192713, 192889, 192890, 192894, 192884, 192866, 192891, 192872, 192881, 192709 ,192883 ,192651, 192888, 192711, 192653 ,192887, 192652, 192865, 192874 ,192868, 192870, 192885, 192867, 192882, 192707, 192896);
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(192708, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192706, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192871, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192905, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192710, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192886, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192869, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192880, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192895, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192713, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192889, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192890, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192894, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192884, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192866, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192891, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192872, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192881, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192709, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192883, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192651, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192888, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192711, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192653, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192887, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192652, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192865, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192874, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192868, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192870, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192885, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192867, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192882, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192707, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn'),
(192896, 1, 0, 0, 64, 0, 100, 1, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Dalaran book - On gossip hello - Despawn');

Steps to reproduce the problem:

  1. Use the sql above
  2. .go game 151820
  3. click the book, it will depawn after 5 secs and upon despawn an other will respawn even if the respawn time for this gobs=10800 secs
SELECT * FROM gameobject WHERE id IN (192708, 192706, 192871, 192905, 192710, 192886, 192869, 192880, 192895, 192713, 192889, 192890, 192894, 192884, 192866, 192891, 192872, 192881, 192709 ,192883 ,192651, 192888, 192711, 192653 ,192887, 192652, 192865, 192874 ,192868, 192870, 192885, 192867, 192882, 192707, 192896);
SELECT * FROM gameobject_template WHERE entry IN (192708, 192706, 192871, 192905, 192710, 192886, 192869, 192880, 192895, 192713, 192889, 192890, 192894, 192884, 192866, 192891, 192872, 192881, 192709 ,192883 ,192651, 192888, 192711, 192653 ,192887, 192652, 192865, 192874 ,192868, 192870, 192885, 192867, 192882, 192707, 192896);
SELECT * FROM pool_gameobject WHERE guid IN (SELECT guid FROM gameobject WHERE id IN (192708, 192706, 192871, 192905, 192710, 192886, 192869, 192880, 192895, 192713, 192889, 192890, 192894, 192884, 192866, 192891, 192872, 192881, 192709 ,192883 ,192651, 192888, 192711, 192653 ,192887, 192652, 192865, 192874 ,192868, 192870, 192885, 192867, 192882, 192707, 192896));
SELECT * FROM pool_template WHERE entry IN (5691,5692,5693,5694,5695,5696,5697,5698);

Branch(es): 3.3.5

TC rev. hash/commit: rev. 446f8b0

@Killyana
Copy link
Member Author

Maybe not only goobers

@Killyana Killyana changed the title Core/GameeObject/pooling: Pooled Goobers respawns instantly if depawneed manually Core/GameObject/Pooling: Pooled Goobers respawns instantly if despawned manually Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant