-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hourly Bells - Not Working on karazhan. #23638
Comments
whats up with these events breaking? :/ |
Maybe the sound files are not linked correctly or the linking has changed? |
That is a possibility, I don't think this event has ever worked in TrinityCore. Shouldn't be too hard to implement. |
OK, thank you for linking the script, it reminded me of something slightly related: Timing in scripts has sometimes been broken in recent years, maybe due to core changes (like in the Ring of Law in Blackrock Depths). I haven't really thought about this Hourly Bells event at all during my years of using the TC environment, so I can't confirm or disprove whether it has ever worked or not. My next idea is that maybe the script timing does not match either the game time or real time, so the sound files don't get played because of the time diff? edit: Remembering my own experience with trying to solve the broken event timing in the Ring of Law, I recommend playing around with the timing & calculation numbers in the script just to see what happens in-game (this might be time-consuming, so I only recommend it if you have lots of time and want to play around with the script just for fun). On the other hand, seeing that the script Addendum: if the event has never worked, the script may need more than just playing around with the numbers. Grasping at straws now: could this possibly, like at all, in theory, have anything to do with the gameobject faction 0 (zero) issue? |
please try after d9ae19d |
All bells works correctly but not the one in Karazhan https://woehead.way-of-elendil.fr/?object=182064 |
isn't there a known issue about game events not spawning objects in instances ? |
not that i know of |
Yep, event spawns are not added to instances. They're skipped altogether right now because it's not trivial (they need to be added to any currently active instance as well as any newly created one). Killyana mentioned it here, not sure if there's an issue open about it. |
gameevent spawn rewrite is on my list after #23603 gets merged. gameevent spawns more-or-less just duplicate the spawn group system (and the quest pool system). event spawns in instances is on the list as part of that. |
I encountered the same issue with #18919 (comment) |
TrinityCore rev. 4074cb0 2019-09-01 19:05:29 +0200 (3.3.5 branch) (Unix, RelWithDebInfo, Static) |
So i works 👍 |
Is there any need for the Karazhan Bell to be linked to the game_event? If changed to a permanent spawn it will work too. |
do they need to be set to active? |
Hi there,
I’m not sure, I’ve not been active with the project for a while now. As far as I know the event is working now.
Kind regards.
|
@Rushor yes, because the logic would pause otherwise and not finish all the bell sounds. If you could get close again say 20 min later, the bells will continue to go off when they shouldn't happen. |
On version : TrinityCore rev. b0db728 2020-01-23 15:33:09 +0100 (3.3.5 branch) (Win64, RelWithDebInfo, Static) I tested it today ( tested in time 18:00 ==>> server time 18:00 ) edit : tested in habitat Stormwind |
updated title to make clear most of bug fixed. |
I checked some information - Edit : |
Duplicate of #26659 |
Don't spawn that object every hour, spawn it always without linking to game event AS IT IS SUPPOSED TO BE and play sound if event is active. |
Description:
The hourly bells event does not work at all.
Current behaviour:
When the clocks strike the start of another hour the clock bells in Stormwind, Orgrimmar, Darkshire, etc.
Expected behaviour:
The hourly bells event should start at the start of the new hour. (E.g 12:00 AM)
Steps to reproduce the problem:
Branch(es):
3.3.5a
TC rev. hash/commit:
TrinityCore rev. c278044+ 2019-07-15 22:28:10 +0200 (3.3.5 branch) (Win64, RelWithDebInfo, Static)
Operating system:
Windows Server 2016 Standard
NOTE: The event does start at the right time and end at the right time however, no bells ring
The text was updated successfully, but these errors were encountered: