Warlock/Pet: Effects of Glyphs persist after removing the glyph

[Jinnaii]

Description:

Effects of glyphs that increase warlock pet stats persist after removing the glyph

Current behaviour:

There are two Glyphs for Warlock pets that increase stats: Glyph of Void Walker (increases Void Walker stamina by 20%) and Glyph of Felguard (increases Felguard attackpower by 20%).

First issue is that these increases should be applied to the pet as soon as you add the glyph. Just resummoning the pet or relogging doesn't work either. Currently, you need to manually dismiss and resummon the pet.

The second issue is that these effects persist even after you remove the glyph. I tried resummoning, manually dismissing and resummoning the pet, relogging and even restarting the server - the stats remain.

Expected behaviour:

Removing the glyph should remove the pets stats boost.

Steps to reproduce the problem:

Create Warlock

.level 50
.learn all my class
.add 42459
.add 42473
.add 6265 6

Summon Voidwalker, write down HP
Add Glyph of Voidwalker
Dismiss
Resummon, write down HP
Remove Glyph of Voidwalker
Dismiss
Resummon, HP doesn't go back to default Value

Summon Felguard, write down Attack power & damage in pet screen
Add Glyph of Felguard
Resummon, write down attack damage again*
Remove Glyph of Felguard
resummon, attack damage doesn't decrease

*in additon, my base values were
209 AP
180-226 Damage
With the Glyph that should give 20% plus my values are now :
220 AP (total +11)
181-228 Damage
That doesnt look correct.

Branch(es):

3.3.5

TC rev. hash/commit:

30823f9

Operating system: Windows 10

[ghost]

I am trying to remember where this is handled. I was thinking about
https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/Spells/spell_pet.cpp
but maybe this needs to be worked on both for the player (warlock) part and the pet?

[Ovahlord]

It's probably a simple exploit that pet auras are being saved while they shouldn't. Pet passives are handled automatically and talents / glyphs usually should get re-cast after each summon as well. But overall, the entire pet system is a clusterfuck since it's from the pre-sniff era

[CraftedRO]

69dda64 also valid for uh dk raisen ally pet when using Glyph of the Ghoul