Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Scripts that Could have SetInCombatWith not working properly #24294

Open
Killyana opened this issue Mar 14, 2020 · 1 comment
Open

Comments

@Killyana
Copy link
Member

Description: We need to check if this scripts starts the combat properly or if they have the same issue as #24268 and need to be fix.

rgrep SetInCombatWith *
EasternKingdoms/ScarletEnclave/chapter5.cpp: me->SetInCombatWith(who);
EasternKingdoms/ScarletEnclave/chapter5.cpp: who->SetInCombatWith(me);
EasternKingdoms/SunwellPlateau/boss_kalecgos.cpp: sathrovar->SetInCombatWith(kalecgosHuman);
EasternKingdoms/SunwellPlateau/boss_kalecgos.cpp: kalecgosHuman->SetInCombatWith(sathrovar);
Kalimdor/BlackfathomDeeps/blackfathom_deeps.cpp: me->SetInCombatWith(player);
Kalimdor/BlackfathomDeeps/blackfathom_deeps.cpp: player->SetInCombatWith(me);
Northrend/Naxxramas/boss_thaddius.cpp: me->SetInCombatWith(stalagg->EnsureVictim());
Northrend/Ulduar/HallsOfLightning/boss_volkhan.cpp: me->SetInCombatWith(who);
Northrend/Ulduar/HallsOfLightning/boss_volkhan.cpp: who->SetInCombatWith(me);
Northrend/Ulduar/HallsOfLightning/boss_volkhan.cpp: me->SetInCombatWith(target);
Northrend/Ulduar/HallsOfLightning/boss_volkhan.cpp: me->SetInCombatWith(who);
Northrend/Ulduar/HallsOfLightning/boss_volkhan.cpp: who->SetInCombatWith(me);
Northrend/Ulduar/HallsOfLightning/boss_ionar.cpp: summoned->SetInCombatWith(target);
Northrend/Ulduar/Ulduar/boss_freya.cpp: me->SetInCombatWith(summoner);
Northrend/Ulduar/Ulduar/boss_hodir.cpp: me->SetInCombatWith(summoner);
Northrend/Ulduar/Ulduar/boss_hodir.cpp: me->SetInCombatWith(summoner);
Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp: sara->SetInCombatWith(me);
Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp: keeper->SetInCombatWith(me);
Northrend/FrozenHalls/HallsOfReflection/halls_of_reflection.cpp: me->SetInCombatWith(leader);
Northrend/FrozenHalls/HallsOfReflection/halls_of_reflection.cpp: leader->SetInCombatWith(me);
Outland/TempestKeep/Eye/boss_kaelthas.cpp: who->SetInCombatWith(me);
Outland/TempestKeep/Eye/boss_kaelthas.cpp: me->SetInCombatWith(who);
Outland/TempestKeep/Eye/boss_kaelthas.cpp: who->SetInCombatWith(me);
Outland/TempestKeep/Eye/boss_kaelthas.cpp: me->SetInCombatWith(who);
Outland/TempestKeep/Eye/boss_kaelthas.cpp: who->SetInCombatWith(me);
Outland/TempestKeep/arcatraz/arcatraz.cpp: me->SetInCombatWith(who);
Outland/TempestKeep/arcatraz/arcatraz.cpp: who->SetInCombatWith(me);
Outland/zone_netherstorm.cpp: me->SetInCombatWith(player);
Outland/GruulsLair/boss_high_king_maulgar.cpp: me->SetInCombatWith(who);
Outland/GruulsLair/boss_high_king_maulgar.cpp: who->SetInCombatWith(me);

Branch(es): 3.3.5

TC rev. hash/commit: rev. 49e77d7

@ghost
Copy link

ghost commented Mar 14, 2020

  1. EasternKingdoms/ScarletEnclave/chapter5.cpp: me->SetInCombatWith(who);
  2. EasternKingdoms/ScarletEnclave/chapter5.cpp: who->SetInCombatWith(me);
  3. EasternKingdoms/SunwellPlateau/boss_kalecgos.cpp: sathrovar->SetInCombatWith(kalecgosHuman);
  4. EasternKingdoms/SunwellPlateau/boss_kalecgos.cpp: kalecgosHuman->SetInCombatWith(sathrovar);
  5. Kalimdor/BlackfathomDeeps/blackfathom_deeps.cpp: me->SetInCombatWith(player);
  6. Kalimdor/BlackfathomDeeps/blackfathom_deeps.cpp: player->SetInCombatWith(me);
  7. Northrend/Naxxramas/boss_thaddius.cpp: me->SetInCombatWith(stalagg->EnsureVictim());
  8. Northrend/Ulduar/HallsOfLightning/boss_volkhan.cpp: me->SetInCombatWith(who);
  9. Northrend/Ulduar/HallsOfLightning/boss_volkhan.cpp: who->SetInCombatWith(me);
  10. Northrend/Ulduar/HallsOfLightning/boss_volkhan.cpp: me->SetInCombatWith(target);
  11. Northrend/Ulduar/HallsOfLightning/boss_volkhan.cpp: me->SetInCombatWith(who);
  12. Northrend/Ulduar/HallsOfLightning/boss_volkhan.cpp: who->SetInCombatWith(me);
  13. Northrend/Ulduar/HallsOfLightning/boss_ionar.cpp: summoned->SetInCombatWith(target);
  14. Northrend/Ulduar/Ulduar/boss_freya.cpp: me->SetInCombatWith(summoner);
  15. Northrend/Ulduar/Ulduar/boss_hodir.cpp: me->SetInCombatWith(summoner);
  16. Northrend/Ulduar/Ulduar/boss_hodir.cpp: me->SetInCombatWith(summoner);
  17. Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp: sara->SetInCombatWith(me);
  18. Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp: keeper->SetInCombatWith(me);
  19. Northrend/FrozenHalls/HallsOfReflection/halls_of_reflection.cpp: me->SetInCombatWith(leader);
  20. Northrend/FrozenHalls/HallsOfReflection/halls_of_reflection.cpp: leader->SetInCombatWith(me);
  21. Outland/TempestKeep/Eye/boss_kaelthas.cpp: who->SetInCombatWith(me);
  22. Outland/TempestKeep/Eye/boss_kaelthas.cpp: me->SetInCombatWith(who);
  23. Outland/TempestKeep/Eye/boss_kaelthas.cpp: who->SetInCombatWith(me);
  24. Outland/TempestKeep/Eye/boss_kaelthas.cpp: me->SetInCombatWith(who);
  25. Outland/TempestKeep/Eye/boss_kaelthas.cpp: who->SetInCombatWith(me);
  26. Outland/TempestKeep/arcatraz/arcatraz.cpp: me->SetInCombatWith(who);
  27. Outland/TempestKeep/arcatraz/arcatraz.cpp: who->SetInCombatWith(me);
  28. Outland/zone_netherstorm.cpp: me->SetInCombatWith(player);
  29. Outland/GruulsLair/boss_high_king_maulgar.cpp: me->SetInCombatWith(who);
  30. Outland/GruulsLair/boss_high_king_maulgar.cpp: who->SetInCombatWith(me);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant