Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gunship battle not crossfaction ready #24540

Open
Aokromes opened this issue May 2, 2020 · 6 comments
Open

gunship battle not crossfaction ready #24540

Aokromes opened this issue May 2, 2020 · 6 comments

Comments

@Aokromes
Copy link
Member

Aokromes commented May 2, 2020

Description:

If one crossfaction group tries to do icc gunship battle they find several problems.

Current behaviour:

part of the party cannot kill the mobs before ship, hacking faction forces you to kill all mobs making the "event" more dificult
you cannot hack all mobs because some must have your faction during event.
you need additional people caring about raid instead dedicate to attack the opposite ship.
if you don't hack part of party cannot do nothing.
maybe https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_faction_champions.cpp can be used to work properly on crossfaction group.

Tell us what should happen instead.
you have one easy party.

Steps to reproduce the problem:

  1. create one crossfaction party, for example 5 horde 5 aliance horde enters 1st
  2. kill the 2 1st boss, use elevator
  3. find part of party cannot kill mobs before gunship
  4. find the aliance part of party cannot attack the aliance ship.

Branch(es):

3.3.5

TC rev. hash/commit:

N/R 3144471 (all since gunship implementation)

Operating system: N/R (Debian 10 x64)

@Rushor
Copy link
Contributor

Rushor commented May 5, 2020

and the gunship battle itself is prolly also not implemented at all. t

here must be a check.

if more horde than alliance players > spawn horde hunship

if more alliance than horde players > spawn alliance hunship

@Aokromes
Copy link
Member Author

Aokromes commented May 6, 2020

it spawns the 1st who enters instance, like forge of souls, pit of saron, halls of reflexion, nexus.
IMHO a way to go can be:
if horde enter 1st and crossfaction-> set all horde npcs 35 and aliance ones 14 else horde 14 aliance 35.

@Aokromes
Copy link
Member Author

no one?

@ghost
Copy link

ghost commented Aug 22, 2020

Not entirely sure, but it looks a little bit like you are asking for something that would more naturally belong to TrinityCoreCustomChanges .

@Aokromes
Copy link
Member Author

no, because other instances are crossfaction ready.

@Fireevil
Copy link

Fireevil commented Apr 7, 2023

any fix for this bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants