Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest] Help Those That Cannot Help Themselves #26478

Open
Bilibox opened this issue Apr 25, 2021 · 9 comments
Open

[Quest] Help Those That Cannot Help Themselves #26478

Bilibox opened this issue Apr 25, 2021 · 9 comments

Comments

@Bilibox
Copy link

Bilibox commented Apr 25, 2021

Description:

Spam clicking the D.E.H.T.A. Trap Smasher counts towards the quest objective multiple times.

Spawning the item in and using it on a Trapped Mammoth Calf will give you the cooldown and 1 second spell cast time, but when you have the quest No cast time is required and the Cooldown is non-existent allowing you to Spam click the item until you have completed the quest.

Expected behaviour:

The item given should have a 15 second cooldown, and only give you progress when casting has finished.

Steps to reproduce the problem:

  1. Grab Help Those That Cannot Help Themselves from Arch Druid Lathorius <D.E.H.T.A.>
  2. Find a Trapped Mammoth Calf.
  3. Spam click the D.E.H.T.A. Trap Smasher on the Trapped Mammoth Calf.

Branch(es):

3.3.5

TC rev. hash/commit:

d5f1fef

Operating system:

Windows

@dr-j
Copy link
Contributor

dr-j commented Apr 26, 2021

This would have been converted to SAI a long time ago if there was not a load of different entries for this object each with own entry of which one is apawned of each entry (im not talking about the calf but the actual trap) which makes writing sai totarget trap problematic when theres like 20+ different entries of trap, much same issue as why ethereum prisons have not been converted to sai either due to huge variation in gobs used

@offl
Copy link
Contributor

offl commented May 22, 2021

Confirmed in 26cc8e1
.go game id 188022
.q a 11876
use provided item once
no cast time, no cooldown
wait 5 sec, don't use item again
use provided item again

It works correctly only if you use item on already closed trap
Moreover it works correctly if count is 8/8

Spell and objects has no script and I even can't understand what exactly triggers the event

@offl
Copy link
Contributor

offl commented May 23, 2021

https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/World/item_scripts.cpp#L222
Indeed, stupid item scripts
Well, that gives some hope

@malcrom
Copy link
Contributor

malcrom commented Oct 8, 2021

You guys comment on stuff but don't fix it.

@CraftedRO
Copy link
Contributor

I feel like nowadays without a sniffer or other tools and probably a paid subscription , you can't fix too much on tc .

@mdX7
Copy link
Member

mdX7 commented Oct 8, 2021

We have a sniffer over at https://github.com/TrinityCore/ymir even supporting tbc ptr, which does not need a sub

@Jinnaix
Copy link
Contributor

Jinnaix commented Oct 8, 2021

It DOES need a sub if you never created a PTR account before.

@malcrom
Copy link
Contributor

malcrom commented Oct 8, 2021

I remember fixing quest back 10 years ago and a new guy did this because it needed c++ to work. It wasn't blizzlike then. I have a few sniffs and will try to fix it up. My C++ isn't the best now but it was non existent back then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants