Quest items in loot boxes disappear from the box after a relog

[jackpoz]

Description

Quest items in loot boxes disappear from the box after relogging.

Expected behaviour

Quest items should still be present in the box, no matter how many relogs are done

Steps to reproduce the problem

1. Create a deathknight
2. .quest add 12720 https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?quest=12720
3. .addi 39418 https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?item=39418
4. Open the box without looting any item
   
5. Relog
6. Open the box
7. The box is empty
   

Branch

3.3.5

TC rev. hash/commit

5094363 and d1e9131 , this issue is not caused by latest loot PR changes

Operating system

Windows 10 x64

Custom changes

None

[jackpoz]

@robinsch you might be interested in this

[jackpoz]

This is caused by

TrinityCore/src/server/game/Loot/LootItemStorage.cpp

Lines 261 to 277 in d1e9131

	for (LootItem const& li : loot->items)
	{
	// Conditions are not checked when loot is generated, it is checked when loot is sent to a player.
	// For items that are lootable, loot is saved to the DB immediately, that means that loot can be
	// saved to the DB that the player never should have gotten. This check prevents that, so that only
	// items that the player should get in loot are in the DB.
	// IE: Horde items are not saved to the DB for Ally players.
	if (!li.AllowedForPlayer(player))
	continue;
	// Don't save currency tokens
	ItemTemplate const* itemTemplate = sObjectMgr->GetItemTemplate(li.itemid);
	if (!itemTemplate || itemTemplate->IsCurrencyToken())
	continue;
	container.AddLootItem(li, trans);
	}

taking into account only loot->items and ignoring loot->quest_items