Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monk and declination of the name #28634

Open
PivanDepolo opened this issue Dec 30, 2022 · 9 comments
Open

Monk and declination of the name #28634

PivanDepolo opened this issue Dec 30, 2022 · 9 comments

Comments

@PivanDepolo
Copy link

Description

If you create a pandaren monk, then every time you enter the game you will have a menu for declining the name

Expected behaviour

Should only be shown once

Steps to reproduce the problem

Just create pandaren monk

Branch

master

TC rev. hash/commit

dbed48b

Operating system

Debian 11

Custom changes

None

@ryanch94
Copy link

image

@PivanDepolo is this what you're referring to?

@ryanch94
Copy link

Seems to happen with other Pandaren classes too, doesn't happen with a human monk

@ryanch94
Copy link

Can't reproduce this on subsequent character loads, it only happens the first time entering with that character

@ryanch94
Copy link

Looks like the channel name "LocalDefense - The Wandering Isle" is too long, error is happening here:

if (packet.ChannelName.length() > MAX_CHANNEL_NAME_STR)

@PivanDepolo
Copy link
Author

image

@PivanDepolo is this what you're referring to?

no.

@PivanDepolo
Copy link
Author

image

@PivanDepolo is this what you're referring to?

I'm talking about "declining the name" in the list of your characters. It appears every time you try to pick up a Pandaren Monk. Should only be shown once

@Shauren
Copy link
Member

Shauren commented Dec 30, 2022

its a russian client exclusive feature

@ryanch94
Copy link

Ahh, I understand now, thanks for clarifying

@ryanch94
Copy link

Created a separate issue for what I found above #28635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants