Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player : Profession - learning inscription does not work correctly #28651

Open
shamage opened this issue Jan 2, 2023 · 4 comments
Open

Player : Profession - learning inscription does not work correctly #28651

shamage opened this issue Jan 2, 2023 · 4 comments

Comments

@shamage
Copy link
Contributor

shamage commented Jan 2, 2023

Description

  • Classic Milling : does not produce new products
  • Unable to learn - Cataclysm Inscription
    Ashampoo_Snap_pondelok 2  januára 2023_12h20m26s_002_World of Warcraft
    Ashampoo_Snap_pondelok 2  januára 2023_12h33m59s_004_

Expected behaviour

everything should work

Steps to reproduce the problem

  1. go to the trainer in Stormwind
    .go cre 313880
    or
    .go xyz -8862.5000 857.195984 99.693100

  2. learn inscription

  3. add an item, for example

.additem 13467
.additem 13466

  1. try classic milling

  2. try to learn Cataclysm Inscription

Branch

master

TC rev. hash/commit

TrinityCore rev. 9c8109e+ 2023-01-01 00:31:54 +0100 (master branch)

Operating system

Win 10 Pro

Custom changes

none

@shamage
Copy link
Contributor Author

shamage commented Jan 2, 2023

I tried the other products randomly and they were produced correctly
Ashampoo_Snap_pondelok 2  januára 2023_13h07m41s_006_

@fluxurion
Copy link
Contributor

The Unable to learn - Cataclysm Inscription would be fixed by #28650

2023-01-02.13-49-09.mp4

@fluxurion
Copy link
Contributor

fluxurion commented Jan 2, 2023

SpellEffect Milling was used before.
Now SPELL_EFFECT_SALVAGE_ITEM & SPELL_EFFECT_CRAFT_SALVAGE_ITEM is used for milling & prospecting also.

For example:
SpellID 382989 - Cataclysm Milling - SPELL_EFFECT_SALVAGE_ITEM
SpellID 382981 - Dragon Isles Milling - SPELL_EFFECT_CRAFT_SALVAGE_ITEM

Both unimplemented yet.

@dio85
Copy link

dio85 commented Jan 2, 2023

Milling and prospecting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants