Crash in Unit::SetPhaseMask

[Maiievs]

Description

Server crash in Unit::SetPhaseMask,
seems to be related to something like applying phasing auras in controlled creatures, while the owner is getting stunned or teleported, causing the creature to despawn while iterating m_controlled.

CrashLog: https://gist.github.com/Maiievs/df62e2ce7f616f644c98e6103f6b5d67

Expected behaviour

No crash

Steps to reproduce the problem

• Create a Warlock character, learn spells and talents
• Enter Icecrown Citadel 25 Heroic and stay close to the entrance, be sure gm mode is disabled
• Cast spell ID 126 = [Eye of Kilrogg]
• Use command .guid and save the guid with the hex syntax like: 0xf1300010b50003de
• So far I was only able to reprodude this next step with the aid of a hack or packet editor.. you need to teleport the 'Eye of Kilrogg' directly to Lady Deathwhisper in position -637.689 2211.285 53.052 (I tested with wowscout and the following commands):

setv ladypos {-637.689,2211.285,53.052}
makepkt 0xee
putg INSERT_HERE_EYE_OF_KILROGG_GUID
put32 0
put16 0
put32 $timestamp
putp $ladypos
putf 0
putf 0
send

• Try to move, server crash

Branch

3.3.5

TC rev. hash/commit

TrinityCore rev. 12bb3ef 2024-04-15 21:12:55 +0200 (3.3.5 branch) (Win64, Debug, Static)
Using SSL version: OpenSSL 1.1.1w 11 Sep 2023 (library: OpenSSL 1.1.1l 24 Aug 2021)
Using Boost version: 1.84.0
Using MySQL version: 80036
Using CMake version: 3.29.0-rc1
Compiled on: Windows 10.0.19045
Automatic database updates are enabled for the following databases: World
Worldserver listening connections on port {}
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1
MMAPs status: Enabled
maps directory located in C:/TcFiles/maps. Total size: 291014951 bytes
vmaps directory located in C:/TcFiles/vmaps. Total size: 657797442 bytes
mmaps directory located in C:/TcFiles/mmaps. Total size: 1961820104 bytes
Using enUS DBC Locale as default. All available DBC locales: enUS
Using World DB: TDB 335.24041
LoginDatabase queue size: 0
CharacterDatabase queue size: 0
WorldDatabase queue size: 0

Operating system

Microsoft Windows 10 Pro

Custom changes

None