Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Warrior] Bladestorm problems. #582

Closed
click opened this issue May 16, 2011 · 20 comments
Closed

[Warrior] Bladestorm problems. #582

click opened this issue May 16, 2011 · 20 comments

Comments

@click
Copy link
Contributor

click commented May 16, 2011

-If you are a warrior and bladestorm, the shaman can hex you and he shouldn't. You will still cause the BS damage to him but when the ability finises until hex finises you can't do damage.
-If the shaman hex you, you can't bladestorm out of it, which was one of the tricks I learned in retail. It says "you can't do that while polymorphed".

@click
Copy link
Contributor Author

click commented May 16, 2011

Author: kbinside
If we talk about bladestorm its not the only problem, you are not immune to hunter slow traps to death kinght slows and grip while bladestorming.

@click
Copy link
Contributor Author

click commented May 16, 2011

Author: imnotyou
If it is a problem of bladestorm and not those classes abilities maybe we should change the ticket title to just "[Warrior] Bladestorm problems" instead of "[Warrior/Shaman] Hex or bladestorm problems." and try to fix them all here, but since I just don't really know maybe it's better to report each thing in a different ticket since devs will have a better time fixing concrete problems instead of a load of ones. Eitherway I will change the title for now.

-Anyways DK's deathgrip is working as intended and even though it had lots of complains in retail, they left it like that since you're not stopping the bladestorm in any way but just change it's target to you so it may be used as an strat in arenas.
http://www.threadmeters.com/hjCObL/Bladestorm_should_negate_Deathgrip/ (cache of a retail thread)
http://www.arenajunkies.com/topic/96335-blade-storm-death-grip/
Other thing is the death grip speed slow gripping things but that is reported on a separate ticked already.

-With DK's desecration it seems it happened in retail too:
http://www.arenajunkies.com/topic/68112-desecration-affects-you-while-you-bladestorm/
''"I could be wrong but I don't think it affects us with storm up. I think, like all snare/spell immunity abilities except BoF, if the snare is applied RIGHT as you use the ability, they both go off. I have blinded in bladestorm, kidney, feared, etc, etc.
I think it may seems like desecration works on bladestorm because the snare is reapplied every x seconds that you stand inside the radius. "''
But then it got fixed:
http://www.arenajunkies.com/topic/85414-32-bug-fixes/
''"Bladestorm: Now properly removes the Snare effect of Desecration in all cases"''

-The DK frost talent of 50% reduced speed seems not to affect a bladestorming warrior.
-The DK Chains of Ice debuff can be aplied on a bladestorming warrior, but it makes no effect even tough he has the debuff after the bladestorm ends. The supposed bug may be something related to this:
http://www.arenajunkies.com/topic/73128-bladestorm/
''"Is anyone else getting deep frozen, Desecrated Ground, Frost Bolt slows and any other slows while you are Bladestorming? These debuffs are not up when I start it they come midway through... "''
So lag or casting it at the same time can make almost ANY spell affect bladestorm, not just chains of ice but frost bolts and almost anything, the same way in retail you could spell reflect 2 spells if they were cast at the same time.
-Hunter freezing traps are indeed affecting bladestorm movement speed, thoug I don't remember exactly if this happened in retail too but seems not to be the case and should be applied the same solution as in desecration maybe.

@click
Copy link
Contributor Author

click commented May 16, 2011

Author: hydraxis
Did it by any chance happen with Mind Control, too?

@EnteringCombat
Copy link

Yes, another bug is that you can get mind controlled during bladestorm (then obviously, you are taken away from your oponnent).

@Griefel
Copy link

Griefel commented Jul 5, 2011

Another issue that wasn't mentioned is the fact that Bladestorm should make you immune to all knockbacks and it doesn't. Along with the other problems the above posters mentioned, I think this ability should be looked at since it's the paramount ability of the warrior class in Arena(alot of strats involve doing kills with bladestorm or using it defensively even) and not only. As it is it cripples the fun of warriors playing on Trinity everywhere and it's one of the facts that makes warriors vastly unpopular class(with many server social ramifications, such as the lack of tanks on low population servers and not only).
Not to mention it represents close to 40% of the Arms tree's utility on it's own.

@MRezaSafari
Copy link

can fix with this query : http://pastebin.com/c55cCCdH
tested and working .

@ghost
Copy link

ghost commented Oct 6, 2011

ok after long time can be fix that isn't;

--[NOTE] : its not a good idea to use this .
--its somekind of hack !!

But really thanks you @drbronx

still bugged at : Hash - 2a34c5e

@ghost ghost assigned QAston Jan 24, 2012
@Star-lion
Copy link
Contributor

currently applying mechanic immunities doesnt work. so bladestorm can be affected by all types of spells

@ghost
Copy link

ghost commented Apr 18, 2012

So you guys have any idea?

@Star-lion
Copy link
Contributor

as i said it has to do with the way mechanic immunities are being handled. i tried figuring out but i didnt hav ethe time

@ghost
Copy link

ghost commented Apr 18, 2012

really thanks for you time :)

@kingtubby
Copy link

Desecration & frost trap doesnt slow anymore.

But now you are not immune to many spells like fear, cyclone, polymorph, hex, freezing trap etc. Can still move and do damage until bladestorm ends.

05ddeb5
tdb 335.11.45

@Star-lion
Copy link
Contributor

yea update your core and you will have better immunities for bladestorm.

@ghost
Copy link

ghost commented Jun 14, 2012

Update to the last core?

@Mysterygamer
Copy link

well i have a weird bladestorm bug, whenever dbw procs (doesn't matter which proc) and if you bladestorm afterwards, you lose the proc completely. But when you get the dbw proc DURING a bladestorm you'll still have the extra haste/str/crit but no visual

@ghost ghost assigned Subv Nov 18, 2012
@L30m4nc3r
Copy link

up.

@ghost
Copy link

ghost commented Jun 26, 2014

down.

@Golrag
Copy link
Contributor

Golrag commented Jul 7, 2014

The reason why you can't bladestorm out of stuns, polymorphs,... is because it has SPELL_AURA_MECHANIC_IMMUNITY_MASK
Which, now, doesn't dispel auras even while the spell has SPELL_ATTR1_DISPEL_AURAS_ON_IMMUNITY. For SPELL_AURA_MECHANIC_IMMUNITY it works fine
Edit:
I used this:

--- a/src/server/game/Spells/Spell.cpp
+++ b/src/server/game/Spells/Spell.cpp
@@ -5514,6 +5514,14 @@ SpellCastResult Spell::CheckCasterAuras() const
         // immune movement impairment and loss of control
         if (m_spellInfo->Id == 42292 || m_spellInfo->Id == 59752 || m_spellInfo->Id == 19574)
             mechanic_immune = IMMUNE_TO_MOVEMENT_IMPAIRMENT_AND_LOSS_CONTROL_MASK;
+
+        if (m_spellInfo->Id == 46924)
+            mechanic_immune = (1 << MECHANIC_SNARE) | (1 << MECHANIC_ROOT)
+            | (1 << MECHANIC_FEAR) | (1 << MECHANIC_STUN)
+            | (1 << MECHANIC_SLEEP) | (1 << MECHANIC_CHARM)
+            | (1 << MECHANIC_SAPPED) | (1 << MECHANIC_HORROR)
+            | (1 << MECHANIC_POLYMORPH) | (1 << MECHANIC_DISORIENTED)
+            | (1 << MECHANIC_FREEZE) | (1 << MECHANIC_TURN);
     }

     bool usableInStun = m_spellInfo->AttributesEx5 & SPELL_ATTR5_USABLE_WHILE_STUNNED;

But now it only works with .cast 46924. When I try to cast it from actionbar / spellbook it still says "Can't do that while stunned"...

@Pro100Hens
Copy link

@Golrag for me not work

@Golrag
Copy link
Contributor

Golrag commented Nov 9, 2014

Mh if I remember correctly, it didn't work for me aswell. Only .cast 46924 worked with that change. If I cast it normally (spellbook / actionbar / /cast) it returned "Can't do that while stunned" without going in Spell::prepare

@Aokromes Aokromes removed the Legacy label Jan 8, 2016
wplatform referenced this issue in WorldOfAzeroth/LegionCommunityServer Jun 28, 2023
[NPC]Vendor] Captain Dirgehammer

Closes #582

See merge request celestial-wow/trinitycore-legion!25
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests