Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Warrior] Spell Reflect isn't reflecting Dk's Deathgrip. #595

Closed
click opened this issue May 16, 2011 · 13 comments
Closed

[Warrior] Spell Reflect isn't reflecting Dk's Deathgrip. #595

click opened this issue May 16, 2011 · 13 comments

Comments

@click
Copy link
Contributor

click commented May 16, 2011

DK's Death Grip should make the DK come to you instead of saying "reflected" and still make the warrior come where the dk is. Don't know about the actual animation it should do those purple rays, but the effect should be the same but the other way.

@click
Copy link
Contributor Author

click commented May 16, 2011

Author: xianx
Note : Spell Reflect is reflecting Kidney Shot / Intercept . The problem is how spells are handled towards spell reflect. The issue doesn't rise from Spell Reflect, but from how these spells are recognized.

@Shadowfang
Copy link

Confirmed. Spell Reflect is not working on Deathgrip.

@Morgoporc
Copy link

Maybe a possible way ...

bool reflect;
reflect = false;

for (std::list::iterator ihit = m_UniqueTargetInfo.begin(); ihit != m_UniqueTargetInfo.end(); ++ihit)
{
if (unitTarget->GetGUID() == ihit->targetGUID) // Found in list
if (ihit->reflectResult == SPELL_MISS_REFLECT)
reflect = true;
}

Someone can explain me why ihit->reflectResult = SPELL_MISS_NONE while that in SpellHitResult reflectResult = SPELL_MISS_REFLECT ?

@Raydor
Copy link

Raydor commented Jul 18, 2013

Still bugged.

@L30m4nc3r
Copy link

spell.cpp
please test.

@@ -583,6 +583,16 @@
         && !(m_spellInfo->AttributesEx & SPELL_ATTR1_CANT_BE_REFLECTED) && !(m_spellInfo->Attributes & SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY)
         && !m_spellInfo->IsPassive() && !m_spellInfo->IsPositive();

+   // Arcane Missiles 
+    if (m_spellInfo->SpellFamilyName == SPELLFAMILY_MAGE && m_spellInfo->SpellIconID == 225 && m_spellInfo->SpellFamilyFlags[0] == 0x200000)
+        m_canReflect = true;
+
+   // Death grip reflected
+   //Position const* pos;
+   if (m_canReflect = m_spellInfo->SpellFamilyName == SPELLFAMILY_DEATHKNIGHT && m_spellInfo->SpellFamilyFlags[0] == 0x2000000 && m_spellInfo->Effects[0].Mechanic == MECHANIC_GRIP);
+       //m_caster->CastSpell(pos->GetPositionX(), pos->GetPositionY(), pos->GetPositionZ(), damage, true);
+        //m_canReflect = true;
+
     CleanupTargetList();
     memset(m_effectExecuteData, 0, MAX_SPELL_EFFECTS * sizeof(ByteBuffer*));

@lainimer
Copy link

lainimer commented Apr 8, 2014

L30m4nc3r not work,confirm

@P-Kito
Copy link
Contributor

P-Kito commented Sep 21, 2014

Any news?

@DoodleZero
Copy link

Death Grip Reflect works for me on new TC revisions
Arcane Missles buggy
Dispel Magic buggy
Penance buggy

@P-Kito
Copy link
Contributor

P-Kito commented Sep 21, 2014

death grip will make the caster get grabbed to the reflector?

@DoodleZero
Copy link

Yea, it will :)
But the biggest problems are Dispel Magic, we need to fix that ....

@P-Kito
Copy link
Contributor

P-Kito commented Sep 22, 2014

Well back to the deathgrip: Do you know where in the code it was handled?
I can't find it 👎

@Rushor
Copy link
Contributor

Rushor commented Sep 22, 2014

for shure, it's not in the spell_death_grip itself ^^

@P-Kito
Copy link
Contributor

P-Kito commented Sep 22, 2014

I have checked that, yes it's not :-)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests