Core/Spells: Implementing some hooks for split damage taken, #7423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1761,12 +1763,14 @@ void Unit::CalcAbsorbResist(Unit* victim, SpellSchoolMask schoolMask, DamageEffe | |||
| continue; | |||
|
|
|||
| int32 splitDamage = CalculatePctN(dmgInfo.GetDamage(), (*itr)->GetAmount()); | |||
| uint32 tempDamage = uint32(splitDamage); | |||
|
|
|||
| (*itr)->GetBase()->CallScriptEffectSplitHandlers((*itr), aurApp, dmgInfo, tempDamage); | |||
There was a problem hiding this comment.
Why do you pass tempDamage as a reference, if you are not going to use it afterwards?
|
all comments have been taken care, pls recheck now ;) |
…e limitation of dmg such auras can split, for example at Hand of Sacrifice. Might have unexpected results, but they are called unexpected for a reason.. .Author Tibbi
|
anyone mind to merge into master? as none commented about whats wrong with this code... |
|
"This pull request cannot be automatically merged." |
Sovak
pushed a commit
to ProjectSkyfire/SkyFire_548
that referenced
this pull request
Nov 29, 2013
…e limitation of dmg such auras can split, for example at Hand of Sacrifice. Might have unexpected results, but they are called unexpected for a reason.. .Author Tibbi closes #6025 Made new one as TrinityCore/TrinityCore#7423 was closed.
raczman
pushed a commit
to raczman/TrinityCore
that referenced
this pull request
Apr 20, 2014
…e limitation of dmg such auras can split, for example at Hand of Sacrifice. Might have unexpected results, but they are called unexpected for a reason.. .Author Tibbi closes TrinityCore#6025 Made new one as TrinityCore#7423 was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the limitation of dmg such auras can split, for example at Hand of Sacrifice. Might have unexpected results, but they are called unexpected for a reason.. .Author Tibbi
closes #6025