New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/Spells: Implementing some hooks for split damage taken, #7423

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Faq
Contributor

Faq commented Aug 17, 2012

fixes the limitation of dmg such auras can split, for example at Hand of Sacrifice. Might have unexpected results, but they are called unexpected for a reason.. .Author Tibbi

closes #6025

@Subv

View changes

Show outdated Hide outdated src/server/game/Entities/Unit/Unit.cpp
@Subv

View changes

Show outdated Hide outdated src/server/scripts/Spells/spell_paladin.cpp
@Vincent-Michael

View changes

Show outdated Hide outdated src/server/scripts/Spells/spell_paladin.cpp
@Faq

This comment has been minimized.

Show comment
Hide comment
@Faq

Faq Aug 17, 2012

Contributor

all comments have been taken care, pls recheck now ;)

Contributor

Faq commented Aug 17, 2012

all comments have been taken care, pls recheck now ;)

Core/Spells: Implementing some hooks for split damage taken, fixes th…
…e limitation of dmg such auras can split, for example at Hand of Sacrifice. Might have unexpected results, but they are called unexpected for a reason.. .Author Tibbi
@Faq

This comment has been minimized.

Show comment
Hide comment
@Faq

Faq Sep 14, 2012

Contributor

anyone mind to merge into master? as none commented about whats wrong with this code...

Contributor

Faq commented Sep 14, 2012

anyone mind to merge into master? as none commented about whats wrong with this code...

@Subv

This comment has been minimized.

Show comment
Hide comment
@Subv

Subv Sep 17, 2012

Contributor

"This pull request cannot be automatically merged."
Please re pull request it.
@Shauren Please take a look at this.

Contributor

Subv commented Sep 17, 2012

"This pull request cannot be automatically merged."
Please re pull request it.
@Shauren Please take a look at this.

@Subv Subv closed this Sep 17, 2012

Sovak pushed a commit to ProjectSkyfire/SkyFire_548 that referenced this pull request Nov 29, 2013

Core/Spells: Implementing some hooks for split damage taken, fixes th…
…e limitation of dmg such auras can split, for example at Hand of Sacrifice. Might have unexpected results, but they are called unexpected for a reason.. .Author Tibbi

closes #6025

Made new one as TrinityCore/TrinityCore#7423 was closed.

raczman pushed a commit to raczman/TrinityCore that referenced this pull request Apr 20, 2014

Core/Spells: Implementing some hooks for split damage taken, fixes th…
…e limitation of dmg such auras can split, for example at Hand of Sacrifice. Might have unexpected results, but they are called unexpected for a reason.. .Author Tibbi

closes TrinityCore#6025

Made new one as TrinityCore#7423 was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment