Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgadm import failing with OCI images #39

Closed
gaige opened this issue May 28, 2023 · 7 comments · Fixed by #40
Closed

imgadm import failing with OCI images #39

gaige opened this issue May 28, 2023 · 7 comments · Fixed by #40

Comments

@gaige
Copy link

gaige commented May 28, 2023

Trying to pull some images from dockerhub is failing due to:

{
  "name": "imgadm",
  "req_id": "9f8ae8c3-be72-49c7-bef3-3f517bf97572",
  "hostname": "XXXX",
  "pid": 10013,
  "component": "source",
  "source": {
    "type": "docker"
  },
  "level": 10,
  "body": "{\"errors\":[{\"code\":\"MANIFEST_UNKNOWN\",\"message\":\"OCI index found, but accept header does not support OCI indexes\"}]}\n",
  "len": 117,
  "msg": "body received",
  "time": "2023-05-28T10:34:36.458Z",
  "src": {
    "file": "/usr/img/node_modules/docker-registry-client/lib/docker-json-client.js",
    "line": 96,
    "func": "finish"
  },
  "v": 0
}

Other images work fine.

Examples of failing images are:

  • nginxproxy/nginx-proxy:latest
  • yuzutech/kroki:0.21.3
@bahamat
Copy link
Member

bahamat commented May 28, 2023

Is this happening with Triton? Or are you trying to use this library separately?

@gaige
Copy link
Author

gaige commented May 28, 2023

It’s happening when importing with imgadm in SmartOS. I’m not using the library directly, just through the SmartOS command.

@bahamat
Copy link
Member

bahamat commented May 28, 2023

What image/registry is this happening with?

@gaige
Copy link
Author

gaige commented May 28, 2023

@bahamat Here are two examples that I ran into:

  • nginxproxy/nginx-proxy:latest
  • yuzutech/kroki:0.21.3

(Any of the tags will do for those images). I haven't been able to isolate a good predictive function on which images won't work, but the yuzutech/kroki image worked last year.

A similar issue for GitLab indicated that fixing it required adding application/vnd.oci.image.manifest.v1+json to the Accept header, but that the JSON response was the same format as the standard Docker Distribution V2 manifest.

@bahamat
Copy link
Member

bahamat commented Jul 19, 2023

See TRITON-2403.

@gaige
Copy link
Author

gaige commented Jul 19, 2023

Thanks, @bahamat . If there's anything I can do to help, please let me know.

@bahamat bahamat linked a pull request Jul 21, 2023 that will close this issue
@bahamat
Copy link
Member

bahamat commented Jul 21, 2023

As far as this repo goes, #40 add support for OCI image mime types. Continue following TRITON-2403 for additional work in sdc-imgapi, sdc-docker, and smartos-live.

@bahamat bahamat closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants