Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to contribute to main and push changes #7

Closed
1 task done
flynneva opened this issue Jan 28, 2022 · 3 comments
Closed
1 task done

How to contribute to main and push changes #7

flynneva opened this issue Jan 28, 2022 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation
Projects

Comments

@flynneva
Copy link
Contributor

flynneva commented Jan 28, 2022

How to Contribute

Typical git development involves the following steps:

  1. Clone the repository you want to change:
    • git clone repository
  2. Checkout new branch to make your changes on:
    • git checkout -b my-new-branch
    • usually the name of the branch should describe its purpose (i.e. add-readme would be a great branch name)
  3. Commit changes locally to your new branch:
    • git add .
    • `git commit -m "my really awesome feature"
  4. Push local changes to remote repositry (github):
    • git push
  5. Make pull request on github:
    • in the browser, go to github.com and go to the Pull Request tab

Why is this important?

As the software team gets larger, more and more people will contribute to the code. If everyone is pushing to the same main branch at the same time...things can get ugly 🚫 and end up causing problems for all the developers on the project.

Doing development this way, the main branch should always be functional code and also the main starting point for everyone to branch off of.

How to fix this

Let's add the above steps to the new How to contribute section in our README.md:

  • add above steps to How to contribute section within README
@flynneva
Copy link
Contributor Author

@An3Dev @BallsAngus @jsakeag @Jtuazon25 I've noticed you guys are just pushing commits directly to main so I've added protections to that branch to stop that 😅

If you want to upload changes to this repo follow the steps above and make a Pull Request, that way we can all review the changes before they happen 👍🏼 💯

@flynneva
Copy link
Contributor Author

Following these steps should also enable us to run CI / CD tests automatically on the Pull Request...which should test the new code you guys write automatically!

@flynneva flynneva added the documentation Improvements or additions to documentation label Jan 28, 2022
@flynneva flynneva added this to To do in 2022 FRC via automation Jan 28, 2022
@An3Dev
Copy link
Member

An3Dev commented Feb 3, 2022

Added the How to contribute section.

@An3Dev An3Dev closed this as completed Feb 3, 2022
2022 FRC automation moved this from To do to Done Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

No branches or pull requests

4 participants