Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Unsupported in PL/SQL Cop Validators" explanation and usage #88

Closed
kibeha opened this issue Sep 23, 2020 · 3 comments
Closed

Add "Unsupported in PL/SQL Cop Validators" explanation and usage #88

kibeha opened this issue Sep 23, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kibeha
Copy link
Collaborator

kibeha commented Sep 23, 2020

I like this additional property! 👍

Originally posted by @PhilippSalvisberg in #86 (comment)

@kibeha
Copy link
Collaborator Author

kibeha commented Sep 23, 2020

!!! missing "Unsupported in PL/SQL Cop Validators" should be added to introduction.md. Probably not under "Severity of the rule". Maybe an addition chapter.

The following rules are currently not supported by a PL/SQL Cop validator:

G-3160 (cannot identify type of a column)
G-5010 (cannot identify logging framework and where it should be applied)
G-8410 (cannot identify where an application lock would make sense)
G-8510 (cannot know where the use of application_info is sensible)
They should be tagged with "!!! missing "Unsupported in PL/SQL Cop Validators"

@kibeha kibeha self-assigned this Sep 23, 2020
@kibeha kibeha added this to the v4.0 milestone Sep 23, 2020
@kibeha kibeha added the enhancement New feature or request label Sep 23, 2020
@PhilippSalvisberg
Copy link
Collaborator

I missed the G-3170 in the previous list. Guidelines without a validator check are documented here https://github.com/Trivadis/plsql-cop-cli/blob/main/validator-limitations.md#guidelines (incl. the reason).

@kibeha
Copy link
Collaborator Author

kibeha commented Oct 15, 2020

Thanks for the link, very helpful 👍

@kibeha kibeha closed this as completed in 2866166 Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants