Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bevy_ecs_tilemap to 0.8 #134

Merged
merged 1 commit into from Nov 16, 2022
Merged

Conversation

bardt
Copy link
Contributor

@bardt bardt commented Nov 14, 2022

I made minimal changes to the code to make it compile.

I assume TilemapTexture::Single is equivalent to the TilemapTexture behaviour from 0.7.

Closes #121

@Trouv
Copy link
Owner

Trouv commented Nov 15, 2022

Thanks for doing this work! It seems the way that bevy_ecs_tilemap positions the tiles in the world has changed pretty drastically, which has messed up all the examples in some way. I expect adjusting to this to be a somewhat involved change so I'm happy to merge this now and adjust in future PRs unless you want to try looking into it in this PR

@bardt
Copy link
Contributor Author

bardt commented Nov 15, 2022

@Trouv I will look into it this evening. Not sure if I will manage to solve it quickly.

@Trouv
Copy link
Owner

Trouv commented Nov 16, 2022

@Trouv I will look into it this evening. Not sure if I will manage to solve it quickly.

No worries - I can just merge this unless you feel like you're close. It probably makes sense to split up the change into multiple PRs anyway

@bardt
Copy link
Contributor Author

bardt commented Nov 16, 2022

@Trouv I don't think I'm super close. So feel free to merge this one.

I'm currently learning the relations between TileMapBundle, TileBundle, and SpatialBundle, and trying to understand what has changed between 0.7 and 0.8 of bevy_ecs_tilemap.

@Trouv Trouv merged commit 7d4d1d0 into Trouv:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to bevy_ecs_tilemap 0.8!
2 participants