Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethslurp: Only find function sigs once per transaction #51

Closed
tjayrush opened this issue May 6, 2017 · 1 comment
Closed

ethslurp: Only find function sigs once per transaction #51

tjayrush opened this issue May 6, 2017 · 1 comment
Assignees
@tjayrush
Labels
enhancement TC-tools:old
Projects
Monitors / Scrapers (prior releases)
Milestone
Release 0.2.0 - G...

Comments

@tjayrush
Copy link
Member

tjayrush commented May 6, 2017

A large part of the time spent is in finding function signatures which is in finishParse. If I stored the function sigs, I wouldn't have to look them up each time I open the file.

From https://github.com/Great-Hill-Corporation/ethslurp/issues/120
@tjayrush tjayrush self-assigned this May 6, 2017
@tjayrush tjayrush added this to the Release 0.2.0 milestone Jul 25, 2017
@tjayrush
Copy link
Member Author

Closing this for #42 which uses the ABI code which will need to be fixed for that bug to be fixed. Noted this concern in that bug.

@tjayrush tjayrush mentioned this issue Aug 19, 2017
Closed
@tjayrush tjayrush added this to To do in Monitors / Scrapers (prior releases) via automation Nov 19, 2018
@tjayrush tjayrush changed the title Only find function sigs once per transaction ethslurp: Only find function sigs once per transaction Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjayrush tjayrush

Labels
enhancement TC-tools:old
Projects
No open projects
Monitors / Scrapers (prior releases)
  
Done
Milestone
Release 0.2.0 - Gravers
Development

No branches or pull requests
1 participant
@tjayrush