Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI parsing, cacheing and usage is very ppor #62

Closed
tjayrush opened this issue May 6, 2017 · 2 comments
Closed

ABI parsing, cacheing and usage is very ppor #62

tjayrush opened this issue May 6, 2017 · 2 comments

Comments

@tjayrush
Copy link
Member

tjayrush commented May 6, 2017

In the getBlock function, I will re-write the data even if the file already exists. We should make the data 'gold' (by checking it against the raw results from parity or geth) and then never write it again. To recast the data (i.e. changes its contents or format), one would have to delete the file explicitly

In a recent case, I had programmed getBlock incorrectly and was writing partial data to the file, thereby corrupting immutable data.

From In a recent case, I had programmed getBlock incorrectly and was writing partial data to the file, thereby corrupting immutable data.

From https://github.com/Great-Hill-Corporation/ethslurp/issues/107

@tjayrush tjayrush changed the title https://github.com/Great-Hill-Corporation/ethslurp/issues/107 Never write the data more than once May 6, 2017
@tjayrush tjayrush self-assigned this May 6, 2017
@tjayrush tjayrush modified the milestone: Release 0.1.0 May 7, 2017
@tjayrush tjayrush changed the title Never write the data more than once ABI parsing, cacheing and usage is very ppor May 11, 2017
@tjayrush
Copy link
Member Author

I should remove most of the code in transactions.cpp related to parsing the chain for [{FUNCTION}]

@tjayrush
Copy link
Member Author

Closing in lieu of #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

1 participant