Conversation
.env.tpl
Outdated
@@ -0,0 +1,7 @@ | |||
PORT=8000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use .env
instead of .env.tpl
? No time to rename stuff, let's get developers to jump right into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you run ./trust build
file .env will be created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if I'm not running docker? by default, it should be there
If .env not working as expected this could be a different problem
Install docker and docker-compose. | ||
|
||
Set in *~/.bashrc* | ||
```export COMPOSE_FILE=docker-compose.yml:docker-compose.dev.yml``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to mount volumes and expose ports - yes.
You can export COMPOSE_FILE in your terminal before using ./trust build and ./trust run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@2at2 few question, otherwise LGTM 👍
.env
Outdated
@@ -1,2 +1,7 @@ | |||
PORT=8000 | |||
|
|||
# mongodb:27017 it's a mongdb address in docker env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this comment? it's not docker specific
.env
Outdated
MONGODB_URI=mongodb://localhost:27017/trust-wallet | ||
|
||
# Main ethereum rpc server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this comment? RPC_SERVER
already has meaning
.env
Outdated
@@ -1,2 +1,7 @@ | |||
PORT=8000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this port required here? it's also specified in docker-compose.dev.yml
No description provided.