Skip to content
This repository has been archived by the owner on Apr 21, 2020. It is now read-only.

Docker env #74

Merged
11 commits merged into from Dec 12, 2017
Merged

Docker env #74

11 commits merged into from Dec 12, 2017

Conversation

2at2
Copy link
Contributor

@2at2 2at2 commented Dec 8, 2017

No description provided.

.env.tpl Outdated
@@ -0,0 +1,7 @@
PORT=8000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use .env instead of .env.tpl ? No time to rename stuff, let's get developers to jump right into it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you run ./trust build file .env will be created.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if I'm not running docker? by default, it should be there
If .env not working as expected this could be a different problem

Install docker and docker-compose.

Set in *~/.bashrc*
```export COMPOSE_FILE=docker-compose.yml:docker-compose.dev.yml```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to mount volumes and expose ports - yes.
You can export COMPOSE_FILE in your terminal before using ./trust build and ./trust run.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@2at2 few question, otherwise LGTM 👍

.env Outdated
@@ -1,2 +1,7 @@
PORT=8000

# mongodb:27017 it's a mongdb address in docker env
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this comment? it's not docker specific

.env Outdated
MONGODB_URI=mongodb://localhost:27017/trust-wallet

# Main ethereum rpc server
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this comment? RPC_SERVER already has meaning

.env Outdated
@@ -1,2 +1,7 @@
PORT=8000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this port required here? it's also specified in docker-compose.dev.yml

@ghost ghost merged commit f9147fe into master Dec 12, 2017
@kolya182 kolya182 deleted the docker-env branch February 20, 2018 00:01
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant