fixed tinting issues #561
fixed tinting issues #561
Conversation
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
| @@ -51,6 +51,12 @@ class RequestCoordinator: Coordinator { | |||
| applicationActivities: nil | |||
| ) | |||
| activityViewController.popoverPresentationController?.barButtonItem = sender | |||
| activityViewController.setActivityCompletion { | |||
There was a problem hiding this comment.
did you consider reusing this functionality?
There was a problem hiding this comment.
yes, it didn't work as intended.
|
@MillerApps does it have any side effects? |
|
@vikmeup as far as I can tell no. |
|
Let's create |
|
Okay, I'll do it tomorrow. |
|
I won't have time to do this today. |
|
@MillerApps That’s like 2 minute fix. I can take on this |
|
@vikmeup Okay, sounds good! |
There was a problem hiding this comment.
@MillerApps can you make this since it's on your fork.
you are part of this repo, you should be able to work on repo branches.
| extension UIActivityViewController { | ||
| func setActivityCompletion(completion: @escaping (() -> Void)) { | ||
| self.completionWithItemsHandler = { _, completed, _, _ in | ||
| if completed || !completed { |
There was a problem hiding this comment.
completed || !completed this covers all cases, is this still necessary?
There was a problem hiding this comment.
removed, didn't seem to affect anything.
| @@ -249,6 +249,12 @@ class BrowserViewController: UIViewController { | |||
| let controller = makeShareController(url: url) | |||
| controller.popoverPresentationController?.sourceView = navigationController.view | |||
| controller.popoverPresentationController?.sourceRect = navigationController.view.centerRect | |||
| controller.setActivityCompletion { | |||
| self.navigationController?.navigationBar.barTintColor = Colors.darkBlue | |||
There was a problem hiding this comment.
can you add this colors to AppStyle ?
Apple doesn't like it
* Fix trustwallet#539, Add HistoryStore * 1. update History primary key: combine url and date 2. only record URL when webView finish loading
* Fix for controller leaking. * Add lazy init for operation queue. * Temp fix for the token search controller.
I am not a fan of this solution. Feel free to make any changes that you think would improve this "hack"!
Here is what it looks like in the app:
