This repository has been archived by the owner on Jun 2, 2019. It is now read-only.
Add BrowserErrorView #434
Merged
Add BrowserErrorView #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Black Duck Security ReportMerging #434 into master will not change security risk. |
|
@hewigovens if we are adding can you share a screenshot/gif? curious to see how that looks. I would love to have same functionality as Safari has tho. |
|
@vikmeup Yes, we can add buttons, I will send you the demo via telegram |
|
@hewigovens let's add reload button |
|
Looking good @hewigovens ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #363, It's actually a overlay view