Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information that Trustroots Foundation is dissolved. #2588

Merged
merged 2 commits into from Oct 5, 2022

Conversation

mariha
Copy link
Contributor

@mariha mariha commented Aug 12, 2022

This change:

Fixes #2585

Copy link
Contributor

@mrkvon mrkvon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

would be nice to be able to merge and deploy stuff...

@mrkvon
Copy link
Contributor

mrkvon commented Aug 12, 2022

btw not sure if we need to extract the translation strings. According to our i18n docs, they'll get extracted when we merge this to master.

Not sure if that still works though. In any case, manual extraction won't do any harm... :)

@chmac
Copy link
Member

chmac commented Aug 13, 2022

I'm opposed to merging this until a valid rationale has been shared in #2585.

@mariha
Copy link
Contributor Author

mariha commented Aug 14, 2022

@mrkvon Given that #2587 had to be done, extract-i18n is not run (successfully).

I created #2589 to fix it.

@chmac I shared my rationale.

@mrkvon
Copy link
Contributor

mrkvon commented Sep 23, 2022

Mergeable by non-owners. Progress discussion? Merge?

@mariha
Copy link
Contributor Author

mariha commented Oct 5, 2022

I'm merging it.

There was a suggestion that the wording may not make best impression on potential new members, but others didn't confirm, clarify or object.

As to me, the question is a way to express our, volunteers team members, insecurities.

At this point (1,5 month after making a PR) I guess I just would really like to move forward and close this, but if others felt the wording is really very bad, please submit a follow-up PR, I'll be happy to review and approve it. I may also do it myself in a free time.

@mariha mariha merged commit 2d1e92b into master Oct 5, 2022
@mariha mariha deleted the dissolved-foundation-info branch October 5, 2022 07:03
@mrkvon
Copy link
Contributor

mrkvon commented Oct 5, 2022

Bold move! 🎉

please submit a follow-up PR, I'll be happy to review and approve it

(emphasis mine) Sounds like a good process! Cheers to doocracy and transparency! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Information about Trustroots Foundation is not accurate any more
3 participants