Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Commit

Permalink
use current URI instead of configured blog URI for OAuth redirectURI (#…
Browse files Browse the repository at this point in the history
…518)

refs TryGhost/Ghost#7907
- rather than forwarding the redirect URI as configured in Ghost we should use the URL that the admin client is currently loaded on when setting the Ghost OAuth `redirectUri` attribute
- fixes issue with the admin app loading inside of the OAuth popup window and not logging in when using https with a registered http redirect uri
  • Loading branch information
kevinansfield committed Feb 1, 2017
1 parent 98f06c7 commit 5383fb1
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions app/torii-providers/ghost-oauth2.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import Oauth2 from 'torii/providers/oauth2-code';
import injectService from 'ember-service/inject';
import computed from 'ember-computed';
import ghostPaths from 'ghost-admin/utils/ghost-paths';

let GhostOauth2 = Oauth2.extend({

config: injectService(),

name: 'ghost-oauth2',
baseUrl: computed(function () {
return `${this.get('config.ghostAuthUrl')}/oauth2/authorize`;
return `${this.get('config.ghostAuthUrl')}/oauth2/authorize/`;
}),
apiKey: computed(function () {
return this.get('config.ghostAuthId');
Expand All @@ -21,7 +22,12 @@ let GhostOauth2 = Oauth2.extend({
// we want to redirect to the ghost admin app by default
init() {
this._super(...arguments);
this.set('redirectUri', `${this.get('config.blogUrl')}/ghost/`);
let adminPath = ghostPaths().adminRoot;
let redirectUri = `${window.location.protocol}//${window.location.host}`;

redirectUri += adminPath;

this.set('redirectUri', redirectUri);
},

open(options) {
Expand Down

0 comments on commit 5383fb1

Please sign in to comment.