Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Commit

Permalink
Revert svg icon stroke changes
Browse files Browse the repository at this point in the history
no issue
- reverts "remove hardcoded icon stroke colors"
- revert "add stroke color to button classes, remove icon-specific stoke/fill styles"

Unfortunately these changes had a larger effect than was initially obvious, will PR if these changes still prove to be useful.
  • Loading branch information
kevinansfield committed Apr 15, 2017
1 parent 4ab3dc1 commit 593c9f3
Show file tree
Hide file tree
Showing 22 changed files with 35 additions and 37 deletions.
4 changes: 1 addition & 3 deletions app/styles/components/settings-menu.css
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,7 @@
.settings-menu-header .close svg {
height: 12px;
width: 12px;
fill: var(--darkgrey);
stroke: var(--darkgrey);
fill: --var(darkgrey);
}

.settings-menu-header.subview h4 {
Expand All @@ -103,7 +102,6 @@

.settings-menu-header.subview .back svg path {
fill: var(--darkgrey);
stroke: var(--darkgrey);
}

/* Content
Expand Down
12 changes: 6 additions & 6 deletions app/styles/patterns/buttons.css
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
text-decoration: none !important;
user-select: none;
fill: color(var(--lightgrey) l(-27%) blackness(+15%));
stroke: color(var(--lightgrey) l(-27%) blackness(+15%));
border-radius: 5px;
transition: all 0.2s ease;

Expand Down Expand Up @@ -82,7 +81,6 @@ fieldset[disabled] .gh-btn {
color: color(var(--darkgrey) l(+15%));
text-shadow: 0 1px 0 #fff;
fill: var(--darkgrey);
stroke: var(--darkgrey);
background: linear-gradient(
color(var(--lightgrey) l(-3%)),
color(var(--lightgrey) l(-8%))
Expand Down Expand Up @@ -122,7 +120,6 @@ fieldset[disabled] .gh-btn {
color: #fff;
text-shadow: 0 -1px 0 rgba(0,0,0,0.1);
fill: #fff;
stroke: #fff;
background: linear-gradient(
color(var(--blue) blackness(+10%)),
color(var(--blue) l(-15%) saturation(-15%))
Expand Down Expand Up @@ -163,7 +160,6 @@ fieldset[disabled] .gh-btn {
color: #fff;
text-shadow: 0 -1px 0 rgba(0,0,0,0.1);
fill: #fff;
stroke: #fff;
background: linear-gradient(
color(var(--green) blackness(+5%)),
color(var(--green) l(-9%) saturation(-9%))
Expand Down Expand Up @@ -205,7 +201,6 @@ fieldset[disabled] .gh-btn {
color: #fff;
text-shadow: 0 -1px 0 rgba(0,0,0,0.1);
fill: #fff;
stroke: #fff;
background: linear-gradient(
color(var(--red) blackness(+10%)),
color(var(--red) l(-15%) saturation(-15%))
Expand Down Expand Up @@ -246,7 +241,6 @@ fieldset[disabled] .gh-btn {
color: #fff;
text-shadow: 0 -1px 0 rgba(0,0,0,0.1);
fill: #fff;
stroke: #fff;
background: linear-gradient(
color(var(--darkgrey) blackness(+10%)),
color(var(--darkgrey) l(-15%) saturation(-15%))
Expand Down Expand Up @@ -305,13 +299,18 @@ fieldset[disabled] .gh-btn {
width: 1em;
height: 1em;
margin-right: 0.5em;
fill: #fff;
}

.gh-btn-icon-right svg {
margin-left: 0.5em;
margin-right: 0;
}

.gh-btn-icon svg path {
stroke: #fff;
}

.gh-btn svg.no-margin {
margin: 0;
}
Expand All @@ -323,6 +322,7 @@ fieldset[disabled] .gh-btn {
/* Success icon */

path.animated-check-circle {
stroke: white;
stroke-dashoffset: 300;
stroke-dasharray: 300;
animation: dash 4s ease-out forwards;
Expand Down
2 changes: 1 addition & 1 deletion public/assets/icons/account-group.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions public/assets/icons/arrow-down-small.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions public/assets/icons/arrow-left-small.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions public/assets/icons/arrow-right-small.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions public/assets/icons/arrow-up-small.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/assets/icons/bookmark-article.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/assets/icons/check-circle.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/assets/icons/eco-globe.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/assets/icons/eco-lightbulb.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/assets/icons/graph-line.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions public/assets/icons/line.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/assets/icons/link.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/assets/icons/list-bullet.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/assets/icons/list-number.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions public/assets/icons/markdown.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/assets/icons/pencil-circle.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/assets/icons/pin.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/assets/icons/plus.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 593c9f3

Please sign in to comment.