Removed unused body classes added by using the StyleBody mixin

no issue - many routes were attaching classes to the `<body>` tag via the `StyleBody` mixin but those classes were never used and applied inconsistently throughout the app
TryGhost · May 20, 2019 · 638d631 · 638d631
1 parent b813b96
commit 638d631
Show file tree

Hide file tree

Showing 13 changed files with 14 additions and 44 deletions.
diff --git a/app/routes/about.js b/app/routes/about.js
@@ -1,8 +1,5 @@
 import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
-import styleBody from 'ghost-admin/mixins/style-body';
 
-export default AuthenticatedRoute.extend(styleBody, {
-    titleToken: 'About',
-
-    classNames: ['view-about']
+export default AuthenticatedRoute.extend({
+    titleToken: 'About'
 });
diff --git a/app/routes/settings/code-injection.js b/app/routes/settings/code-injection.js
@@ -1,13 +1,11 @@
 import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
 import CurrentUserSettings from 'ghost-admin/mixins/current-user-settings';
-import styleBody from 'ghost-admin/mixins/style-body';
 import {inject as service} from '@ember/service';
 
-export default AuthenticatedRoute.extend(styleBody, CurrentUserSettings, {
+export default AuthenticatedRoute.extend(CurrentUserSettings, {
     settings: service(),
 
     titleToken: 'Settings - Code injection',
-    classNames: ['settings-view-code'],
 
     beforeModel() {
         this._super(...arguments);

diff --git a/app/routes/settings/design.js b/app/routes/settings/design.js
@@ -2,14 +2,12 @@ import $ from 'jquery';
 import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
 import CurrentUserSettings from 'ghost-admin/mixins/current-user-settings';
 import RSVP from 'rsvp';
-import styleBody from 'ghost-admin/mixins/style-body';
 import {inject as service} from '@ember/service';
 
-export default AuthenticatedRoute.extend(styleBody, CurrentUserSettings, {
+export default AuthenticatedRoute.extend(CurrentUserSettings, {
     settings: service(),
 
     titleToken: 'Settings - Design',
-    classNames: ['settings-view-design'],
 
     beforeModel() {
         this._super(...arguments);

diff --git a/app/routes/settings/integration.js b/app/routes/settings/integration.js
@@ -1,13 +1,11 @@
 import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
 import CurrentUserSettings from 'ghost-admin/mixins/current-user-settings';
-import styleBody from 'ghost-admin/mixins/style-body';
 import {inject as service} from '@ember/service';
 
-export default AuthenticatedRoute.extend(styleBody, CurrentUserSettings, {
+export default AuthenticatedRoute.extend(CurrentUserSettings, {
     router: service(),
 
     titleToken: 'Settings - Integrations',
-    classNames: ['settings-view-integration'],
 
     init() {
         this._super(...arguments);

diff --git a/app/routes/settings/integrations.js b/app/routes/settings/integrations.js
@@ -1,13 +1,11 @@
 import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
 import CurrentUserSettings from 'ghost-admin/mixins/current-user-settings';
-import styleBody from 'ghost-admin/mixins/style-body';
 import {inject as service} from '@ember/service';
 
-export default AuthenticatedRoute.extend(styleBody, CurrentUserSettings, {
+export default AuthenticatedRoute.extend(CurrentUserSettings, {
     settings: service(),
 
     titleToken: 'Settings - Integrations',
-    classNames: ['settings-view-integrations'],
 
     beforeModel() {
         this._super(...arguments);

diff --git a/app/routes/settings/integrations/amp.js b/app/routes/settings/integrations/amp.js
@@ -1,13 +1,11 @@
 import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
 import CurrentUserSettings from 'ghost-admin/mixins/current-user-settings';
-import styleBody from 'ghost-admin/mixins/style-body';
 import {inject as service} from '@ember/service';
 
-export default AuthenticatedRoute.extend(styleBody, CurrentUserSettings, {
+export default AuthenticatedRoute.extend(CurrentUserSettings, {
     settings: service(),
 
     titleToken: 'AMP',
-    classNames: ['settings-view-integrations-amp'],
 
     beforeModel() {
         this._super(...arguments);

diff --git a/app/routes/settings/integrations/slack.js b/app/routes/settings/integrations/slack.js
@@ -1,13 +1,11 @@
 import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
 import CurrentUserSettings from '../../../mixins/current-user-settings';
-import styleBody from 'ghost-admin/mixins/style-body';
 import {inject as service} from '@ember/service';
 
-export default AuthenticatedRoute.extend(styleBody, CurrentUserSettings, {
+export default AuthenticatedRoute.extend(CurrentUserSettings, {
     settings: service(),
 
     titleToken: 'Slack',
-    classNames: ['settings-view-integrations-slack'],
 
     beforeModel() {
         this._super(...arguments);

diff --git a/app/routes/settings/integrations/unsplash.js b/app/routes/settings/integrations/unsplash.js
@@ -1,15 +1,13 @@
 import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
 import CurrentUserSettings from '../../../mixins/current-user-settings';
 import UnsplashObject from 'ghost-admin/models/unsplash-integration';
-import styleBody from 'ghost-admin/mixins/style-body';
 import {inject as service} from '@ember/service';
 
-export default AuthenticatedRoute.extend(styleBody, CurrentUserSettings, {
+export default AuthenticatedRoute.extend(CurrentUserSettings, {
     config: service(),
     settings: service(),
 
     titleToken: 'Unsplash',
-    classNames: ['settings-view-integrations-unsplash'],
 
     // reload settings to ensure we have latest values and pre-configure
     // Unsplash to be active if the server doesn't have any unsplash setting

diff --git a/app/routes/settings/labs.js b/app/routes/settings/labs.js
@@ -1,13 +1,11 @@
 import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
 import CurrentUserSettings from 'ghost-admin/mixins/current-user-settings';
-import styleBody from 'ghost-admin/mixins/style-body';
 import {inject as service} from '@ember/service';
 
-export default AuthenticatedRoute.extend(styleBody, CurrentUserSettings, {
+export default AuthenticatedRoute.extend(CurrentUserSettings, {
     settings: service(),
 
     titleToken: 'Settings - Labs',
-    classNames: ['settings'],
 
     beforeModel() {
         this._super(...arguments);

diff --git a/app/routes/signout.js b/app/routes/signout.js
@@ -1,14 +1,11 @@
 import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
-import styleBody from 'ghost-admin/mixins/style-body';
 import {inject as service} from '@ember/service';
 
-export default AuthenticatedRoute.extend(styleBody, {
+export default AuthenticatedRoute.extend({
     notifications: service(),
 
     titleToken: 'Sign Out',
 
-    classNames: ['ghost-signout'],
-
     afterModel(/*model, transition*/) {
         this.notifications.clearAll();
         this.session.invalidate();

diff --git a/app/routes/site.js b/app/routes/site.js
@@ -1,11 +1,8 @@
 import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
-import styleBody from 'ghost-admin/mixins/style-body';
 
-export default AuthenticatedRoute.extend(styleBody, {
+export default AuthenticatedRoute.extend({
     titleToken: 'Site',
 
-    classNames: ['view-site'],
-
     model() {
         return (new Date()).valueOf();
     }

diff --git a/app/routes/staff/index.js b/app/routes/staff/index.js
@@ -1,14 +1,12 @@
 import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
 import CurrentUserSettings from 'ghost-admin/mixins/current-user-settings';
-import styleBody from 'ghost-admin/mixins/style-body';
 import {inject as service} from '@ember/service';
 
-export default AuthenticatedRoute.extend(styleBody, CurrentUserSettings, {
+export default AuthenticatedRoute.extend(CurrentUserSettings, {
     infinity: service(),
     session: service(),
 
     titleToken: 'Staff',
-    classNames: ['view-team'],
 
     model() {
         return this.session.user;

diff --git a/app/routes/staff/user.js b/app/routes/staff/user.js
@@ -1,13 +1,10 @@
 /* eslint-disable camelcase */
 import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
 import CurrentUserSettings from 'ghost-admin/mixins/current-user-settings';
-import styleBody from 'ghost-admin/mixins/style-body';
 
-export default AuthenticatedRoute.extend(styleBody, CurrentUserSettings, {
+export default AuthenticatedRoute.extend(CurrentUserSettings, {
     titleToken: 'Staff - User',
 
-    classNames: ['team-view-user'],
-
     model(params) {
         return this.store.queryRecord('user', {slug: params.user_slug, include: 'count.posts'});
     },