🐛 Fixed confusing messaging around .yml extension being allowed for r…

…outes.yaml uploads (#1140) no issue The server never supported uploading .yml files * updated uploader `invalid extension` error message to be more abstract * fixed routes uploader validation allowing .yml files
TryGhost · Apr 3, 2019 · a5bfd36 · a5bfd36
1 parent 4ce8a72
commit a5bfd36
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/app/components/gh-uploader.js b/app/components/gh-uploader.js
@@ -181,7 +181,7 @@ export default Component.extend({
 
         if (!extension || extensions.indexOf(extension.toLowerCase()) === -1) {
             let validExtensions = `.${extensions.join(', .').toUpperCase()}`;
-            return `The image type you uploaded is not supported. Please use ${validExtensions}`;
+            return `The file type you uploaded is not supported. Please use ${validExtensions}`;
         }
 
         return true;

diff --git a/app/controllers/settings/labs.js b/app/controllers/settings/labs.js
@@ -26,7 +26,7 @@ const IMPORT_MIME_TYPES = [
 const JSON_EXTENSION = ['json'];
 const JSON_MIME_TYPE = ['application/json'];
 
-const YAML_EXTENSION = ['yml', 'yaml'];
+const YAML_EXTENSION = ['yaml'];
 const YAML_MIME_TYPE = [
     'text/vnd.yaml',
     'application/vnd.yaml',

diff --git a/app/templates/settings/labs.hbs b/app/templates/settings/labs.hbs
@@ -307,7 +307,7 @@
                             {{/if}}
                         </span>
                     </button>
-                    <span><a href="#" {{action "downloadFile" "settings/routes/yaml"}} data-test-link="download-routes">Download current routes.yml</a></span>
+                    <span><a href="#" {{action "downloadFile" "settings/routes/yaml"}} data-test-link="download-routes">Download current routes.yaml</a></span>
                 {{/if}}
 
                 <div style="display:none">