Update title of page in editor to current title of post. #1072
Conversation
There was a problem hiding this comment.
Hey @Neatoro 👋 Thanks for looking at this! I think this approach needs a bit of a rethink, we already have a system in place for working with titles that can be used for this case. There are also a few changes needed to make use of the tools Ember provides rather than reaching out for external dependencies.
|
@kevinansfield I tried to implement you requested changes, hope they look better now :) If you wonder I forced pushed on my branch to rebase the review comment commits into the same. |
|
Seems like the tests are failing for some reason 🤔 I checked by triggering my own repo against travis and there different tests and a different amount are failing. (https://travis-ci.org/Neatoro/Ghost-Admin/builds/454706025) Are they unstable or do I miss something here? |
|
I think I found the issue regarding the failing tests. Somehow he has problems with the router. I need to figure out how to fix them hopefully within the next hours. |
|
Fixed the failing test. @kevinansfield could you review it again? |
refs #10088 Change moved the title information into a function that returns the correct title or if no title is set for now "Editor". That should help with multiple Editor tabs open.
refs #1072 Changed the logic to use the route object of the controller. Afterwards overwrote the route object in the tests to use a stubbed version. Added an unit tests that verifies that the updateTitle method is called.
…tle` observer method
|
Thanks @Neatoro. I've pushed changes to your branch so that I can merge 😄 |
|
@kevinansfield Thank you! |
refs TryGhost/Ghost#10088
The change moved the title information into a function that returns the
correct title or if no title is set for now "Editor" for the editor route. That should help
with multiple Editor tabs open since it now displays the correct title.
Before:
After:
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
ember testfrom the repo root - will becore/clientif working from the submodule in Ghost).