This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
馃帹 clean up hover state borders in night shift #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vikaspotluri123
commented
Dec 2, 2018
vikaspotluri123
commented
- Not sure if there's an issue ref, I couldn't find one
- Improvements to input fields and button borders and colors in night shift on hover / focus
- Some (at least one) of the issues arise because colors get redefined for the dark theme in spirit, which messes up the final result (due to color-mod being used)
- There definitely needs to be some input re: color choices, they're currently a mish-mash of similar colors from similar rules
peterzimon
reviewed
Jan 21, 2019
peterzimon
reviewed
Jan 21, 2019
peterzimon
reviewed
Jan 21, 2019
peterzimon
suggested changes
Jan 21, 2019
There was a problem hiding this comment.
Hey @vikaspotluri123,
Thanks a lot for the changes 馃槃, I left some comments for minor refinements.
Thank you,
Zimo
|
Thanks @peterzimon! Updated 馃槉 |
|
Found a couple other places that could use some love:
|
peterzimon
approved these changes
Jan 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.