Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Add new theme directory links to Ghost Admin #1078

Merged
merged 2 commits into from
Dec 4, 2018

Conversation

JohnONolan
Copy link
Member

In the same spirit as the recent addition of links to the integrations directory in Ghost Admin, this adds some links and CTAs to a few top themes, the marketplace/directory, and the theme documentation.

All of this is an effort to help Ghost users with discoverability of what's possible with Ghost when browsing the admin area.

image

@ErisDS ErisDS requested review from ErisDS and removed request for kevinansfield December 3, 2018 15:41
@coveralls
Copy link

coveralls commented Dec 3, 2018

Coverage Status

Coverage remained the same at 71.357% when pulling 4ac8016 on JohnONolan:theme-directory into bfe9be3 on TryGhost:master.

@peterzimon
Copy link
Contributor

Looks cool!

Just a couple of questions of minor details:

  • do we always show the same five themes or are they shuffled in any way?
  • do you have the same hover options on the thumbnails as on marketplace? if no, then what happens on click (download link or preview)? all make sense in diff. ways...
  • maybe we could style "FREE" in green as on Marketplace?

@m1guelpf
Copy link

m1guelpf commented Dec 3, 2018

A direct install for free themes would be super cool, probably out of scope tho...

@JohnONolan
Copy link
Member Author

do we always show the same five themes or are they shuffled in any way?

Fixed theme selection and order for balanced quality and colour contrast

do you have the same hover options on the thumbnails as on marketplace? if no, then what happens on click (download link or preview)? all make sense in diff. ways...

You go to the theme listing, which usually contains link to preview :)

maybe we could style "FREE" in green as on Marketplace?

I thought about this but maybe too many colours?

@JohnONolan
Copy link
Member Author

A direct install for free themes would be super cool, probably out of scope tho...

Def would be cool in future - think it would probably be one of those things which ends up being at on of work to solve all the different edge cases though

@allouis allouis merged commit 10cd759 into TryGhost:master Dec 4, 2018
@truekasun
Copy link

This is a cool feature but when a blog is up and running, we hardly change the live theme to a completely different theme and it's taking an unnecessary space from the design page.

Can we add a property to the config file to hide this section?

Your thoughts on this are appreciated. This is just something came up into my mind when I visit the design page. :)

@JohnONolan
Copy link
Member Author

JohnONolan commented Dec 4, 2018 via email

@truekasun
Copy link

truekasun commented Dec 4, 2018

Well actually, as a developer I update my theme regularly with new features, optimizations and bugfixes.

So other than the articles page, most of my time is spent there in the design page uploading and re-uploading my theme updates.

When I visit the design page, we could upload the theme update with a single click earlier, but now we have to scroll to find the upload button. ;)

I know you have right to modify Ghost as you need it to be. This is just a suggestion from a person who's also in love with Ghost.

</div>
</div>
</a>
<a class="td-cta-box td-cta-docs" href="https://marketplace.ghost.org" target="_blank" rel="noopener">

This comment was marked as abuse.

This comment was marked as abuse.

JohnONolan added a commit that referenced this pull request Dec 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants