This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
✨ Added Slack username option. #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghart
force-pushed
the
slack-username-9735
branch
from
469d9e7
to
a62df3a
Compare
|
I noticed I'm getting pretty inconsistent client tests at this point btw. At first I assumed it was my local setup, but obviously Travis thinks the same thing. I don't see anything obvious about my changes that would cause such a cascade failure, and the failures themselves seem to be inconsistent, but will keep looking. |
3 tasks
greghart
force-pushed
the
slack-username-9735
branch
2 times, most recently
from
bc1bb95
to
50884c9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client changes for TryGhost/Ghost#9735
See TryGhost/Ghost#10285