This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
🎨 Added gravatars for member avatars #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterzimon Styling is pretty much done here but would need your opinion on the animation and general looks (both were taken almost 1:1 from user avatar styles with minor adjustments) |
naz
force-pushed
the
members-gravatar
branch
from
861c309
to
27940ee
Compare
naz
force-pushed
the
members-gravatar
branch
2 times, most recently
from
e8daedb
to
cc34c9b
Compare
no issue - When an email has a valid gravatar handle it displays an image instead of initials for the member
- Very much inspired by user gravatar styling with the difference of having initials as a placeholder when there is no gravatar for given email
- Helper is reusable and could be applied in other places - Aslo solves a problem of flickering images when loading a component
- There is a need to duplicate class property useage in the component and doing that through splatttibute feature is unsafe as pointed ou here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
@rishabhgrg would love a second pair 👀 on the Ember code. Thaaanks!