This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Fixes change password button auto reset state #1568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs #11789 - Enable autoreset parameter - Invert css classes definitions to allow the button to turn green for the success state
m1kl
changed the title
m1kl
changed the title
m1kl
changed the title
m1kl
changed the title
|
Hey @m1kl , thanks for submitting PR for this fix. Have included this change in another PR which also switches on auto-reset for all task buttons by default so it doesn't need to be added explicitly. Closing this in favor of changes there to resolve conflicts and merge, have added credits ref to this PR in commit description. 😄 |
rishabhgrg
added a commit
to rishabhgrg/Ghost-Admin
that referenced
this pull request
Jun 4, 2020
closes TryGhost/Ghost#11789 - Invert css classes definitions for red/green buttons to allow the button to turn green for the success state Credits - https://github.com/m1kl - TryGhost#1568
rishabhgrg
added a commit
that referenced
this pull request
Jun 4, 2020
closes TryGhost/Ghost#11789 - Invert css classes definitions for red/green buttons to allow the button to turn green for the success state Credits - https://github.com/m1kl - #1568
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to allow the change password button to turn green for the success state and to automatically reset.
Fixes TryGhost/Ghost#11789 (Use case described in the referenced issue)