This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Tag metadata UI #1632
Merged
Tag metadata UI #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @peterzimon! Would you be able to check this PR out and give it some design review? There should be a solid base for everything here and only some tweaks needed, but if you run into any larger issues - let me know! |
no refs. - moved tag color to the right of tag name to make it more discoverable
no refs. - fixed focused color field size - moved error messages under name + color input field
|
yo @allouis
-> there's a flashing error message below the fields which disappears. what would be expected is to not be able to save and show the error message (similarly to e.g. the name field) |
|
I've fixed this now :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds new UI to the tag setting form, allowing the user to set the metadata properties on the tag object.
Prerequisites
You need to be on Ghost
masterand have run the 3.23 migrations.knex-migrator migrate --v 3.23 --forcemv content/data/ghost-dev.db{,.old} && yarn startScreenshots