This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Fixed tag metadata fields not being populated #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #12190 The "scratch" concept was being used incorrectly for codeinjection fields and was not initialised with all the required fields.
|
Hey @kevinansfield can you check that I've correctly used our "scratch" concept here? |
In this instance I'm not sure there's a need for scratch values at all, the only reason I can think of for why they would be used here is so that the title shown at the top of the screen doesn't update whilst you're typing. Fixing the scratch value usage is a bigger refactor though, this change is working so we can merge and come back to it later 👍 |
|
👯 Thanks!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes TryGhost/Ghost#12190
The "scratch" concept was being used incorrectly for codeinjection
fields and was not initialised with all the required fields.