This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Remove smartquotes #876
Merged
Remove smartquotes #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's only one instance of smartquotes, removed in the edited editor.css file
ref: TryGhost/Ghost#8867
I haven't been able to reproduce the issue in my version of Edge, but that doesn't really mean anything, since my version of Edge can't seem to run the Ghost admin interface without crashing. I'm going to attribute that to user error (because I've made a lot of core changes to Windows) but I will post updates when I get access to another Windows computer
Whether or not this is causing an issue in Edge, it's probably a good idea to not use smartquotes since it's only used in one place (for consistency and whatnot) 馃槅