fix(start): fix warning behavior (#1475)

TryGhost · May 22, 2021 · c809873 · c809873
1 parent fb4d624
commit c809873
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/lib/commands/start.js b/lib/commands/start.js
@@ -32,16 +32,15 @@ class StartCommand extends Command {
             return;
         }
 
-        const url = instance.config.get('url');
+        instance.checkEnvironment();
 
-        if (this.system.environment === 'production' && url.startsWith('http://')) {
+        if (this.system.environment === 'production' && instance.config.get('url', '').startsWith('http://')) {
             this.ui.log([
                 'Using https on all URLs is highly recommended. In production, SSL is required when using Stripe.',
                 'Support for non-https admin URLs in production mode is deprecated and will be removed in a future version.'
             ].join('\n'), 'yellow');
         }
 
-        instance.checkEnvironment();
         await this.runCommand(DoctorCommand, {categories: ['start'], ...argv, quiet: true});
         await this.ui.run(() => instance.start(argv.enable), `Starting Ghost: ${instance.name}`, runOptions);
 

diff --git a/test/unit/commands/start-spec.js b/test/unit/commands/start-spec.js
@@ -130,7 +130,7 @@ describe('Unit: Commands > Start', function () {
             expect(run.calledOnce).to.be.true;
             expect(start.calledOnce).to.be.true;
             expect(log.calledTwice).to.be.true;
-            expect(instance.config.get.calledThrice).to.be.true;
+            expect(instance.config.get.calledTwice).to.be.true;
         });
 
         it('doesn\'t log if quiet is set to true', async function () {
@@ -157,7 +157,7 @@ describe('Unit: Commands > Start', function () {
             expect(run.calledOnce).to.be.true;
             expect(start.calledOnce).to.be.true;
             expect(log.called).to.be.false;
-            expect(instance.config.get.calledOnce).to.be.true;
+            expect(instance.config.get.called).to.be.false;
         });
     });