Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme checks grouping improvements #217

Closed
wants to merge 5 commits into from

Conversation

naz
Copy link
Contributor

@naz naz commented Apr 12, 2019

closes #215

@naz naz requested a review from peterzimon April 12, 2019 07:59
@peterzimon
Copy link
Contributor

@gargol looks awesome, I think there are just two minor refinements:

  1. let's have an empty row before Checking theme compatibility... (otherwise it's getting too much crammed with the command)
  2. let's have three dots after Checking theme compatibility... (now it's just 2)

naz added a commit that referenced this pull request Apr 16, 2019
refs #210

- Tweaks based on this feedback - #217 (comment)
@naz
Copy link
Contributor Author

naz commented Apr 16, 2019

@peterzimon the tweak above landed in master with a680d78 . They were not too related to this changeset, so pushed them right away 👍

@naz
Copy link
Contributor Author

naz commented Apr 16, 2019

These will need an additional review of how new 'fatal' group is used in Ghost-Admin and gscan web client. Will be done once other priorities are cleared.

@naz
Copy link
Contributor Author

naz commented Oct 22, 2019

To be revived once this issue becomes a priority again

@naz naz closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce new groupings for check results
2 participants