Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unable to build on 0.11.3 #158

Closed
jlongster opened this issue Jun 27, 2013 · 4 comments
Closed

unable to build on 0.11.3 #158

jlongster opened this issue Jun 27, 2013 · 4 comments

Comments

@jlongster
Copy link

Node 0.11.3 came out yesterday, and it appears that node-sqlite3 won't build on it. Looks like there's some API changes? See http://blog.nodejs.org/

> sqlite3@2.1.10 install /Users/james/projects/mint-service/node_modules/jugglingdb-sqlite3/node_modules/sqlite3
> node-gyp rebuild

  ACTION binding_gyp_action_before_build_target_unpack_sqlite_dep deps/sqlite-autoconf-3071700/sqlite3.c
Extracting...
Done!
  TOUCH Release/obj.target/action_before_build.stamp
  CC(target) Release/obj.target/sqlite3/deps/sqlite-autoconf-3071700/sqlite3.o
  LIBTOOL-STATIC Release/sqlite3.a
  CXX(target) Release/obj.target/node_sqlite3/src/database.o
In file included from ../src/database.cc:5:
../src/database.h:42:46: warning: 'New' is deprecated [-Wdeprecated-declarations]
            callback = Persistent<Function>::New(cb_);
                                             ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
In file included from ../src/database.cc:6:
../src/statement.h:90:46: warning: 'New' is deprecated [-Wdeprecated-declarations]
            callback = Persistent<Function>::New(cb_);
                                             ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
../src/database.cc:17:58: warning: 'New' is deprecated [-Wdeprecated-declarations]
    constructor_template = Persistent<FunctionTemplate>::New(t);
                                                         ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
3 warnings generated.
  CXX(target) Release/obj.target/node_sqlite3/src/node_sqlite3.o
In file included from ../src/node_sqlite3.cc:11:
../src/database.h:42:46: warning: 'New' is deprecated [-Wdeprecated-declarations]
            callback = Persistent<Function>::New(cb_);
                                             ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
In file included from ../src/node_sqlite3.cc:12:
../src/statement.h:90:46: warning: 'New' is deprecated [-Wdeprecated-declarations]
            callback = Persistent<Function>::New(cb_);
                                             ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
2 warnings generated.
  CXX(target) Release/obj.target/node_sqlite3/src/statement.o
In file included from ../src/statement.cc:6:
../src/database.h:42:46: warning: 'New' is deprecated [-Wdeprecated-declarations]
            callback = Persistent<Function>::New(cb_);
                                             ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
In file included from ../src/statement.cc:7:
../src/statement.h:90:46: warning: 'New' is deprecated [-Wdeprecated-declarations]
            callback = Persistent<Function>::New(cb_);
                                             ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
../src/statement.cc:18:58: warning: 'New' is deprecated [-Wdeprecated-declarations]
    constructor_template = Persistent<FunctionTemplate>::New(t);
                                                         ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
../src/statement.cc:585:50: warning: 'New' is deprecated [-Wdeprecated-declarations]
        baton->completed = Persistent<Function>::New(completed);
                                                 ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
../src/statement.cc:596:56: warning: 'New' is deprecated [-Wdeprecated-declarations]
    each_baton->async->item_cb = Persistent<Function>::New(each_baton->callback);
                                                       ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
../src/statement.cc:597:61: warning: 'New' is deprecated [-Wdeprecated-declarations]
    each_baton->async->completed_cb = Persistent<Function>::New(each_baton->completed);
                                                            ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
../src/statement.cc:763:17: error: unexpected namespace name 'Buffer': expected expression
                Buffer *buffer = Buffer::New(((Values::Blob*)field)->value, ((Values::Blob*)field)->length);
                ^
../src/statement.cc:763:25: error: use of undeclared identifier 'buffer'
                Buffer *buffer = Buffer::New(((Values::Blob*)field)->value, ((Values::Blob*)field)->length);
                        ^
../src/statement.cc:764:43: error: use of undeclared identifier 'buffer'
                value = Local<Value>::New(buffer->handle_);
                                          ^
6 warnings and 3 errors generated.
make: *** [Release/obj.target/node_sqlite3/src/statement.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:103:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:789:12)
gyp ERR! System Darwin 12.3.0
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/james/projects/mint-service/node_modules/jugglingdb-sqlite3/node_modules/sqlite3
gyp ERR! node -v v0.11.3
gyp ERR! node-gyp -v v0.9.6
gyp ERR! not ok 
npm ERR! weird error 1
npm ERR! not ok code 0
jlong-16106:~/projects/mint-service(master)% npm install git+https://github.com/developmentseed/node-sqlite3.git
npm WARN package.json mint-service@0.1.0 No repository field.
npm WARN package.json mint-service@0.1.0 No readme data.
npm WARN package.json co@1.4.0 No repository field.
npm WARN package.json nunjucks@0.1.9 No repository field.

^C%                                                                                                                  
jlong-16106:~/projects/mint-service(master)% npm install git+https://github.com/developmentseed/node-sqlite3.git
npm WARN package.json mint-service@0.1.0 No repository field.
npm WARN package.json mint-service@0.1.0 No readme data.
npm WARN package.json co@1.4.0 No repository field.
npm WARN package.json nunjucks@0.1.9 No repository field.
^C%                                                                                                                  
jlong-16106:~/projects/mint-service(master)% git clone https://github.com/developmentseed/node-sqlite3.git
Cloning into 'node-sqlite3'...
remote: Counting objects: 2200, done.
remote: Compressing objects: 100% (1104/1104), done.
remote: Total 2200 (delta 1141), reused 2108 (delta 1065)
Receiving objects: 100% (2200/2200), 9.62 MiB | 2.48 MiB/s, done.
Resolving deltas: 100% (1141/1141), done.
jlong-16106:~/projects/mint-service(master)% rm -r node-sqlite3/ 
override r--r--r--  james/staff for node-sqlite3//.git/objects/pack/pack-1374ec63257221c421b45fa39954ab4d8f4757ca.idx
? ^C                                                                                                                
jlong-16106:~/projects/mint-service(master)% rm -fr node-sqlite3/
jlong-16106:~/projects/mint-service(master)% npm install git+https://github.com/developmentseed/node-sqlite3.git
npm WARN package.json mint-service@0.1.0 No repository field.
npm WARN package.json mint-service@0.1.0 No readme data.
npm WARN package.json co@1.4.0 No repository field.
npm WARN package.json nunjucks@0.1.9 No repository field.





npm WARN engine sqlite3@2.1.10: wanted: {"node":">= 0.6.13 && < 0.11.0"} (current: {"node":"v0.11.3","npm":"1.2.25"})
npm http GET https://registry.npmjs.org/tar.gz
npm http 304 https://registry.npmjs.org/tar.gz
npm WARN engine tar.gz@0.1.1: wanted: {"node":"0.8.x"} (current: {"node":"v0.11.3","npm":"1.2.25"})
npm http GET https://registry.npmjs.org/fstream
npm http GET https://registry.npmjs.org/tar
npm http GET https://registry.npmjs.org/commander
npm http 304 https://registry.npmjs.org/fstream
npm http 304 https://registry.npmjs.org/commander
npm http 304 https://registry.npmjs.org/tar
npm http GET https://registry.npmjs.org/keypress
npm http GET https://registry.npmjs.org/rimraf
npm http GET https://registry.npmjs.org/mkdirp
npm http GET https://registry.npmjs.org/graceful-fs
npm http GET https://registry.npmjs.org/inherits
npm http GET https://registry.npmjs.org/inherits
npm http GET https://registry.npmjs.org/block-stream
npm http 304 https://registry.npmjs.org/keypress
npm http 304 https://registry.npmjs.org/graceful-fs
npm http 304 https://registry.npmjs.org/inherits
npm http 304 https://registry.npmjs.org/mkdirp
npm http 304 https://registry.npmjs.org/rimraf
npm http 304 https://registry.npmjs.org/inherits
npm http 304 https://registry.npmjs.org/block-stream

> sqlite3@2.1.10 install /Users/james/projects/mint-service/node_modules/sqlite3
> node-gyp rebuild

  ACTION deps_sqlite3_gyp_action_before_build_target_unpack_sqlite_dep deps/sqlite-autoconf-3071700/sqlite3.c
Extracting...
Done!
  TOUCH Release/obj.target/deps/action_before_build.stamp
  CC(target) Release/obj.target/sqlite3/deps/sqlite-autoconf-3071700/sqlite3.o
  LIBTOOL-STATIC Release/sqlite3.a
  CXX(target) Release/obj.target/node_sqlite3/src/database.o
In file included from ../src/database.cc:5:
../src/database.h:42:46: warning: 'New' is deprecated [-Wdeprecated-declarations]
            callback = Persistent<Function>::New(cb_);
                                             ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
In file included from ../src/database.cc:6:
../src/statement.h:90:46: warning: 'New' is deprecated [-Wdeprecated-declarations]
            callback = Persistent<Function>::New(cb_);
                                             ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
../src/database.cc:17:58: warning: 'New' is deprecated [-Wdeprecated-declarations]
    constructor_template = Persistent<FunctionTemplate>::New(t);
                                                         ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
3 warnings generated.
  CXX(target) Release/obj.target/node_sqlite3/src/node_sqlite3.o
In file included from ../src/node_sqlite3.cc:11:
../src/database.h:42:46: warning: 'New' is deprecated [-Wdeprecated-declarations]
            callback = Persistent<Function>::New(cb_);
                                             ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
In file included from ../src/node_sqlite3.cc:12:
../src/statement.h:90:46: warning: 'New' is deprecated [-Wdeprecated-declarations]
            callback = Persistent<Function>::New(cb_);
                                             ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
2 warnings generated.
  CXX(target) Release/obj.target/node_sqlite3/src/statement.o
In file included from ../src/statement.cc:6:
../src/database.h:42:46: warning: 'New' is deprecated [-Wdeprecated-declarations]
            callback = Persistent<Function>::New(cb_);
                                             ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
In file included from ../src/statement.cc:7:
../src/statement.h:90:46: warning: 'New' is deprecated [-Wdeprecated-declarations]
            callback = Persistent<Function>::New(cb_);
                                             ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
../src/statement.cc:18:58: warning: 'New' is deprecated [-Wdeprecated-declarations]
    constructor_template = Persistent<FunctionTemplate>::New(t);
                                                         ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
../src/statement.cc:585:50: warning: 'New' is deprecated [-Wdeprecated-declarations]
        baton->completed = Persistent<Function>::New(completed);
                                                 ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
../src/statement.cc:596:56: warning: 'New' is deprecated [-Wdeprecated-declarations]
    each_baton->async->item_cb = Persistent<Function>::New(each_baton->callback);
                                                       ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
../src/statement.cc:597:61: warning: 'New' is deprecated [-Wdeprecated-declarations]
    each_baton->async->completed_cb = Persistent<Function>::New(each_baton->completed);
                                                            ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:597:38: note: 'New' declared here
  V8_DEPRECATED(static Persistent<T> New(Handle<T> that));
                                     ^
/Users/james/.node-gyp/0.11.3/deps/v8/include/v8.h:88:35: note: expanded from macro 'V8_DEPRECATED'
#define V8_DEPRECATED(declarator) declarator __attribute__ ((deprecated))
                                  ^
../src/statement.cc:763:17: error: unexpected namespace name 'Buffer': expected expression
                Buffer *buffer = Buffer::New(((Values::Blob*)field)->value, ((Values::Blob*)field)->length);
                ^
../src/statement.cc:763:25: error: use of undeclared identifier 'buffer'
                Buffer *buffer = Buffer::New(((Values::Blob*)field)->value, ((Values::Blob*)field)->length);
                        ^
../src/statement.cc:764:43: error: use of undeclared identifier 'buffer'
                value = Local<Value>::New(buffer->handle_);
                                          ^
6 warnings and 3 errors generated.
make: *** [Release/obj.target/node_sqlite3/src/statement.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:103:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:789:12)
gyp ERR! System Darwin 12.3.0
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/james/projects/mint-service/node_modules/sqlite3
gyp ERR! node -v v0.11.3
gyp ERR! node-gyp -v v0.9.6
gyp ERR! not ok 
npm ERR! weird error 1
npm ERR! not ok code 0
@jlongster
Copy link
Author

I was able to build it on 0.11.2, but all the warnings were still there. The last 3 errors are probably the most interesting.

@springmeyer
Copy link
Contributor

should be fixed now, can you pull from master for the time being?

@jlongster
Copy link
Author

Wow, bloody fast. It does seem to work now. Thanks!

@springmeyer
Copy link
Contributor

cheers

@jlongster jlongster mentioned this issue Jun 28, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlongster @springmeyer