Added options.resolve function allowing resolveId override and options.paths will fallback to relative paths #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking for review @TrySound |
|
@TrySound , any perspective on merging this? I'd be great! |
DanielHara
added a commit
to DanielHara/postcss-inline-svg
that referenced
this pull request
Feb 28, 2022
Or @hudochenkov? |
2tunnels
pushed a commit
to moneypark/postcss-inline-svg
that referenced
this pull request
Oct 7, 2022
* apply TrySound#66 * relative path before absolute path * Upgrade css-select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally planned to extend the "paths" option, but deemed that to be too unclear. Instead added a new "resolve" option that take the same arguments as
resolveId(file, url, opts) => string. As an added bonus internalresolveIdwill now attempt to resolve file relatively if "paths" don't return any meaningful results.Closes: #57