Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to update snapshot #33

Closed
kylemh opened this issue Aug 7, 2019 · 3 comments · Fixed by #34
Closed

Provide ability to update snapshot #33

kylemh opened this issue Aug 7, 2019 · 3 comments · Fixed by #34

Comments

@kylemh
Copy link
Contributor

kylemh commented Aug 7, 2019

Currently, if there's a desired size mis-match, I'm required to:

  • delete the file
  • delete { matchSnapshot: true } from plugin config
  • create build (new snapshot defined)
  • re-add { matchSnapshot: true } to plugin config

This feels like it can be improved.

@TrySound
Copy link
Owner

TrySound commented Aug 8, 2019

I usually set matchSnapshot to true only in ci

@kylemh
Copy link
Contributor Author

kylemh commented Aug 8, 2019

Ah I see. That makes more sense. Perhaps some tiny documentation reflecting that then? The naming of the variable indicated to me that it should always be true.

@TrySound
Copy link
Owner

TrySound commented Aug 8, 2019

Do you want to send a PR with clarification?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants