Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In 1.20 pre1 / RC1 no light emiting from Hand/Armour #5

Closed
WarLord211 opened this issue May 14, 2023 · 6 comments
Closed

In 1.20 pre1 / RC1 no light emiting from Hand/Armour #5

WarLord211 opened this issue May 14, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@WarLord211
Copy link

Describe the bug

With the new 1.20 pre releases the Torches emit no light when in Hand.
On the Ground they Do.

Also the enchanted shield emits no light.

in 1.19.4 everything is fine

Steps to reproduce

get 1.20 pre1 and load the datapack

Expected behavior

No response

Additional context

No response

@WarLord211 WarLord211 added the bug Something isn't working label May 14, 2023
@Tschipcraft
Copy link
Owner

Thanks for the bug report. This happened because Mojang decided to rename the key word alternative to any_of used in predicates in Snapshot 23w18a.
I'm currently trying to find a way for maintaining backwards compatibility, but an easy fix for a version that only works in 1.20 or above would be to rename any occurrences of minecraft:alternative to minecraft:any_of in all JSON files located in ../data/dynamiclights/predicates/.

@WarLord211
Copy link
Author

the renaming fixed it for me.
THX

@WarLord211 WarLord211 changed the title In 1.20 pre1 no light emiting from Hand/Armour In 1.20 pre1 / RC1 no light emiting from Hand/Armour Jun 4, 2023
@WarLord211
Copy link
Author

Hi with the 1.20 Release Candidate 1
It stopped again working.

Standart version and with the modifikation you mentioned before

@Tschipcraft
Copy link
Owner

That's weird, there is nothing stated in the game changelogs that changed anything significant. I'll have to take a closer look at it

@Tschipcraft Tschipcraft self-assigned this Jun 5, 2023
@Tschipcraft
Copy link
Owner

I found a way to not use the alternative or any_of keyword at all inside the predicates and managed to maintain backwards compatibility down to Minecraft 1.17 with the latest commit. Let me know if you experience any other issues with it 🎉

@WarLord211
Copy link
Author

tested the master and it works nice :)
Thx for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants