Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From a distance, part of the mobs aren't invisible #3

Closed
retropele opened this issue Mar 7, 2023 · 2 comments
Closed

From a distance, part of the mobs aren't invisible #3

retropele opened this issue Mar 7, 2023 · 2 comments
Assignees
Labels
enhancement Changes for an existing feature

Comments

@retropele
Copy link

retropele commented Mar 7, 2023

Describe the bug

Before the spawning animation starts (at a particular distance) emissive textures like spider eyes and endermen eyes if enabled just float around and can be seen moving, as well as Endermen's block if they are carrying one.

The same goes for armour worn by zombies/skeletons which you can see empty with no mob inside before the animation starts.

Any solutions, or just unfixable? I love this.

Steps to reproduce

  1. Play with emissive textures on.
  2. Go outside and wait until enemy spawns.
  3. Observe visible eyes, held items/blocks and worn armour walking around.
  4. Get close and see these disappear for a moment as the mob spawns below ground.

Expected behavior

Mobs to be fully invisible before they spawn in.

Additional context

I know this may be due to an incongruent mob spawning distance vs spawning animation distance, however I don't know where to find a spawning animation distance toggle.

@retropele retropele added the bug Something isn't working label Mar 7, 2023
@Tschipcraft
Copy link
Owner

Tschipcraft commented Mar 7, 2023

Thanks <3

This is a known annoyance.
Right now, the data pack is designed to be as unintrusive as possible to other mods that may alter spawning rates and check for any mobs and their worn loot nearby. So the mobs that have not played their animation yet, stay where they are with the loot they've been given.
Sadly, I can't hide the worn armor/held tools and any emissive parts of an entity with the invisibility effect.

One possible solution for armor and tools could be storing them somewhere else in the entity (maybe in a container with nbt in a slot that doesn't render (e.g. the feet slot)).
The other option would be to literally hide the mobs under the ground, but then they will not be able to move and interact with farms, for example.

I will most likely add an option for one of the possible solution in the future (as well as an animation distance slider).

@retropele
Copy link
Author

Thanks so much for answering me. I see I'm asking for an enhancement then instead!

I don't run farms, so having it being a toggle would be great someday (though again I know there could be big issues with just shoving a bunch of mobs underground all the time), and the slider sounds ideal, because what I would probably personally do is just make it so the animation distance is closer to my entity spawn distance, even if that meant I rarely see the animation - it's very scary and immersive and weird.

One of the best mods I've used in ages and really surprisingly low impact, so thanks so much for it!! I'll try and change the tag on this to "enhancement" but if not, you're welcome to change it if you can.

Thank you for the cool mod!!

@Tschipcraft Tschipcraft added enhancement Changes for an existing feature and removed bug Something isn't working labels Mar 28, 2023
@Tschipcraft Tschipcraft self-assigned this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes for an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants